Git Product home page Git Product logo

Comments (11)

alcohol avatar alcohol commented on July 29, 2024

It is not irrelevant, there were issues with the previous path.

from docker.

dkarlovi avatar dkarlovi commented on July 29, 2024

I'm guessing you mean #13. Makes sense, it's unfortunate this failed without any warning or anything.

Closing, thanks.

from docker.

alcohol avatar alcohol commented on July 29, 2024

I can understand this was an inconvenient change.

I believe we should add some thorough documentation regarding how to use Composer in CI/CD flows. While our image makes it very simple to quickly run Composer anywhere, doing it properly actually would lean more towards creating your own image and making use of the new multistage options Docker now offers. See #22 also.

from docker.

dkarlovi avatar dkarlovi commented on July 29, 2024

Might consider emitting a warning if the container can see the cache folder is not inside a non-overlay mount point?

from docker.

alcohol avatar alcohol commented on July 29, 2024

That is not desirable, since generally there is no need to have the cache folder inside of a mount point.

from docker.

dkarlovi avatar dkarlovi commented on July 29, 2024

I'm talking from within the container. For a container, mount point = volume.

Meaning: if you know $COMPOSER_ROOT/cache doesn't resolve to a mounted volume, you're writing cache inside the container which basically means you're not using cache at all, as the container's lifespan is one command run long.

from docker.

alcohol avatar alcohol commented on July 29, 2024

Yes, and since this is the default behaviour, we are not going to throw warnings about this.

from docker.

dkarlovi avatar dkarlovi commented on July 29, 2024

If Composer's default behaviour is not to use cache, not throwing warnings about not using cache from this image seems reasonable, didn't know it was the default.

from docker.

alcohol avatar alcohol commented on July 29, 2024

You are confusing Composer's default behaviour and the default use-case this image is build for. They are entirely separate things.

The default use-case for this image is single-run throw-away commands.

from docker.

dkarlovi avatar dkarlovi commented on July 29, 2024

It might be crystal clear to a maintainer, but to a average user this image might be interpreted like "Composer in a box", in which case Composer (and its behaviour/defaults/etc) is the product, Docker image is just the delivery method. This point goes further by the fact the image version is exactly equal to the Composer version it's packaging.

I'd expect the image to behave exactly like Composer itself does, but that's my opinion, you're the one putting in the work. 👍 Nvm then, thanks for your time.

from docker.

alcohol avatar alcohol commented on July 29, 2024

I think that the average user understands how Docker works. Also, this is where documentation already provides enough information.

https://github.com/docker-library/docs/blob/00def8bd8d5fc4a83f001dc46324e9c85a230343/composer/content.md#L19-L26

from docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.