Comments (3)
I found out that type is initialized with empty string, so the condition is_null
in function getType
will never be true.
Possbile fixes:
-
Initialize type with null:
https://github.com/commercetools/commercetools-sdk-php-v2/blob/master/lib/commercetools-api/src/Models/Message/MessageModel.php#L31
public const DISCRIMINATOR_VALUE = null;
-
change condition to empty:
https://github.com/commercetools/commercetools-sdk-php-v2/blob/master/lib/commercetools-api/src/Models/Message/MessageModel.php#L405
if (empty($this->type)) {
from commercetools-sdk-php-v2.
Thanks for the report. I'm already working on a fix for this particular issue. It has to be fixed in the code generator as it touches the way the model classes are built.
from commercetools-sdk-php-v2.
I just released 6.0.2 which fixes the issue for the MessageModel class.
The next minor release will fix it also for other discriminating model classes. Will also take a look to instantiate the correct child class inside collections when dealing with a discriminator model
from commercetools-sdk-php-v2.
Related Issues (20)
- WithExpand not working HOT 4
- MyCartDraftModel do not support for set shippingMode HOT 4
- introduce builder inheritance HOT 1
- Missing inventoryMode property for MyCartAddLineItemActionModel model
- REUSE
- TO BE DELETED
- PHP SDK: Delete Review By ID / Change State
- TypeError caused by mapper() in MapperSequence
- Add a method to retrieve the last element from a collection HOT 2
- test
- Switch block checks wrong statusCode HOT 3
- PHP SDK ME Endpoint support HOT 1
- Missing helper methods HOT 2
- Upgrade psr/cache to v3 to make SDK compatible with newer Symfony versions HOT 3
- Laravel 9 compatibility HOT 10
- PHP SDK V2 - Generated Documentation Content
- setCustom is missing in CustomerAddressBuilder inside importer
- Support current versions of psr/log HOT 2
- Not able to set empty values for category description HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from commercetools-sdk-php-v2.