Git Product home page Git Product logo

Comments (3)

wbm-sbasler avatar wbm-sbasler commented on June 14, 2024

I found out that type is initialized with empty string, so the condition is_null in function getType will never be true.

Possbile fixes:

  1. Initialize type with null:
    https://github.com/commercetools/commercetools-sdk-php-v2/blob/master/lib/commercetools-api/src/Models/Message/MessageModel.php#L31
    public const DISCRIMINATOR_VALUE = null;

  2. change condition to empty:
    https://github.com/commercetools/commercetools-sdk-php-v2/blob/master/lib/commercetools-api/src/Models/Message/MessageModel.php#L405
    if (empty($this->type)) {

from commercetools-sdk-php-v2.

jenschude avatar jenschude commented on June 14, 2024

Thanks for the report. I'm already working on a fix for this particular issue. It has to be fixed in the code generator as it touches the way the model classes are built.

from commercetools-sdk-php-v2.

jenschude avatar jenschude commented on June 14, 2024

I just released 6.0.2 which fixes the issue for the MessageModel class.

The next minor release will fix it also for other discriminating model classes. Will also take a look to instantiate the correct child class inside collections when dealing with a discriminator model

from commercetools-sdk-php-v2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.