Use ISerializerService in Dependency Injection Setup about commercetools-dotnet-core-sdk-v2 HOT 5 CLOSED

Just opened a PR which adds the API specific marker interfaces. For backwards compatibility the registration of the SerializerService classes are still there, but internally it will be only retrieved by it's interface.

So it should be possible to mock or replace them e.g. in tests.

We need the marker interfaces as the serialization configuration can be a little bit different and even conflicting between the APIs.

from commercetools-dotnet-core-sdk-v2.

Yes. That's the idea behind it. And for testing purposes you could inject whatever implementation you mark with the interface ;)

from commercetools-dotnet-core-sdk-v2.

We would more likely have to create a marker interface for each of the SerializerService implementations, as they hold specific configurations for the supported API.

But overall yes we are open for supporting a interface instead of a specific implementation

from commercetools-dotnet-core-sdk-v2.

Okay I must say that I don't fully understand the purpose of a marker interface and how and where it is used. But I trust, that you guys know the potential benefits of using it.
So do you think my sugestet idea is any good? Or do you think it should be implemented differently, with the mentioned marker interface? Or not implemented at all?

from commercetools-dotnet-core-sdk-v2.

Hey, perfect! Thank you for the fast implementation. Really appreciate it.

I now understand better what you meant by the marker interfaces. After seeing your changes and implementation.

Just for my understanding:
I now can just use in the DI setup: (when the new version is released)

...
services.UseCommercetoolsApiSerialization();
...

And the use the marker interface in the constructor for example like this:

    private readonly IApiSerializerService _serializerService;

    public ExampleService(IApiSerializerService serializerService)
    {
        _serializerService = serializerService;
    }

Thank you a lot again :)

from commercetools-dotnet-core-sdk-v2.