Cabana lets you create/save an invalid dbc file about cabana HOT 1 OPEN

There are multiple things wrong with the dbc file created causing them to not load into Vector CANdb++. One on file I worked on from opendbc, and downloaded out of Cabana. I had to do a few things to get it to open without a parsing error.

• The CM_ field should only be per network node, not for random comments in the file.
• The CM_ fields needed to be before the VAL_ fields
• A blank BS_ needed to be added before the BU_ field.

Interestingly, a // based comment is ignored by the Vector CANdb++ parser, but not round-tripped. I'm not sure what other parsers ignore it.

Running a consistency check is a whole other subject, with the key issue there that signal names are reused multiple times, primarily COUNTER and CHECKSUM.

from cabana.