Git Product home page Git Product logo

Comments (4)

espen avatar espen commented on August 22, 2024

Yes. But this reveals another issue: comfy_paginate is defined in Comfy::Admin::Cms::BaseController and thus not available from Comfy::Blog::PostsController. I assume this should be moved to Comfy::Cms::BaseController or a new application controller which can be shared between the admin controllers and the normal site controllers. Happy to make a pull request just not sure on the implications. Any advice @GBH ?

Current workaround:

  1. copy https://github.com/comfy/comfortable-mexican-sofa/blob/b8a22f258412cef56c8c906fe6b7f2f40b9b4f43/app/controllers/comfy/admin/cms/base_controller.rb#L57-L66 to your application controller.

  2. change to @posts = comfy_paginate(scope, limit) in https://github.com/comfy/comfy-blog/blob/master/app/controllers/comfy/blog/posts_controller.rb#L33

from comfy-blog.

GBH avatar GBH commented on August 22, 2024

I'll fix it. I wish I cold reuse one defined in CMS, but it's in a different controller scope.

from comfy-blog.

GBH avatar GBH commented on August 22, 2024

Grab blog 1.12.3 for the fix

from comfy-blog.

jaehocho avatar jaehocho commented on August 22, 2024

Thank you!

from comfy-blog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.