Git Product home page Git Product logo

Comments (4)

rvantonder avatar rvantonder commented on August 11, 2024 1

The pattern above is trying to match the whole file before the first = __builtin_annot_intval probably ?

Yes :) Others have run into this before so you're not alone. I think the right move might be to emit a warning for this sort of pattern. Tracking in #146. I added a little note on this in the docs:

You almost never want to start a template with :[hole], since it matches everything including newlines up to its suffix. This can make things slow. :[hole] is typically useful inside balanced delimiters.


I guess it should still find something ?

It probably would, if the timeout is higher (set with -timeout 10 for 10 seconds). There is a performance issue related to this, which would make this operation faster, but matching everything up to the = is still probably not the intended operation. Hope that helps.

from comby.

giltho avatar giltho commented on August 11, 2024 1

It does help ! I fixed my pattern, happy to hear a warning will be emitted and the doc improving.
Thank you for your reactivity, Comby's a great project !

from comby.

rvantonder avatar rvantonder commented on August 11, 2024 1

Addressed in #147.

from comby.

giltho avatar giltho commented on August 11, 2024

Wait it's just me being dumb isn't it ? The pattern should be

:[[x]] = __builtin_annot_intval("symb_int", :[[x]]);

The pattern above is trying to match the whole file before the first = __builtin_annot_intval probably ?

I don't know if the fact that it times out is really an issue then. I guess it should still find something ?
Sorry for submitting an issue if it is not one, I'll let you decide if that should be closed.

from comby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.