Comments (6)
The main thing is that adding a regression test for this case would not prevent other bugs in this class of issue in other APIs, duplicating all the tests to cover name mapping would be unfeasible, and adding name mapping to all the existing tests may be distracting in the documentation. There's probably a way forward, but for now I think we can just go with the fix since you've tested it manually
from scalasql.
From a cursory look, it appears OnConflict.renderSql()
needs to pass column names through config.columnNameMapper
from scalasql.
Sounds reasonable. Could you open a pull request? You can test it locally by running ./mill -i __.publishLocal
to get a version you can try out on your machine to verify it fixes the issue
from scalasql.
@lihaoyi I created a PR that fixes my issue and passes all the tests. Do you have a suggestion with respect to adding a test that specifically tests the issue? It would necessitate adding a new table with at least one kebab_case primary key.
from scalasql.
I think we're fine merging as is.
from scalasql.
0.1.5 should be out with your fix
from scalasql.
Related Issues (12)
- Scala 3 Support (1000USD Bounty) HOT 11
- flatMap is unsafe HOT 1
- Huge memory increase in `renderSql` with scala 2.13.13 (OOM) HOT 3
- Invalid published scalasql-core POM file (Error resolving scalasql_2.13 0.1.0) HOT 2
- Using the H2Dialect, how does one retrieve auto-generated keys? HOT 2
- Nested/Embedded datastructures possible? HOT 1
- How to select database schema? HOT 6
- Scala reflect error HOT 2
- Add support for Microsoft SQL server (500USD Bounty) HOT 3
- Compilation fails with Scala 3 -Xcheck-macros
- Imported custom TypeMapper doesn't work in Scala 2.13.14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scalasql.