onConflictUpdate() does not apply database-level column naming convention about scalasql HOT 6 CLOSED

The main thing is that adding a regression test for this case would not prevent other bugs in this class of issue in other APIs, duplicating all the tests to cover name mapping would be unfeasible, and adding name mapping to all the existing tests may be distracting in the documentation. There's probably a way forward, but for now I think we can just go with the fix since you've tested it manually

from scalasql.

From a cursory look, it appears OnConflict.renderSql() needs to pass column names through config.columnNameMapper

from scalasql.

Sounds reasonable. Could you open a pull request? You can test it locally by running ./mill -i __.publishLocal to get a version you can try out on your machine to verify it fixes the issue

from scalasql.

@lihaoyi I created a PR that fixes my issue and passes all the tests. Do you have a suggestion with respect to adding a test that specifically tests the issue? It would necessitate adding a new table with at least one kebab_case primary key.

from scalasql.

I think we're fine merging as is.

from scalasql.

0.1.5 should be out with your fix

from scalasql.