Comments (7)
lick = like. so happy it worked
from colyseus-unity-sdk.
The problem is exactly on this check: https://github.com/gamestdio/colyseus-unity3d/blob/f08f47d5758e0228f3e0e91b6a1b50dd1fe7aa7f/Assets/Plugins/Colyseus/DeltaListener/Compare.cs#L61-L65
It returns true
for string changes, whereas it should return false
and perform a "replace"
operation: https://github.com/gamestdio/colyseus-unity3d/blob/f08f47d5758e0228f3e0e91b6a1b50dd1fe7aa7f/Assets/Plugins/Colyseus/DeltaListener/Compare.cs#L87-L99
from colyseus-unity-sdk.
Just added a failing test scenario confirming the issue: f08f47d
from colyseus-unity-sdk.
thanks endel.
from colyseus-unity-sdk.
dear endel
I checked it. It gave the same result as before. could you check it again please.
from colyseus-unity-sdk.
Hey @aloani20, are you sure you checked the right version? Here's how the updated Compare.cs
looks like: https://github.com/gamestdio/colyseus-unity3d/blob/0.5.6/Assets/Plugins/Colyseus/DeltaListener/Compare.cs#L64-L68
from colyseus-unity-sdk.
thanks Endel woks lick a charm.
from colyseus-unity-sdk.
Related Issues (20)
- Error creating .unitypackage (GitHub Workflow) HOT 1
- "Local schema mismatch from server." only in unity android build HOT 1
- Cannot overwrite message callback HOT 2
- JsonSerializationException when receiving a message from server in WebGL export HOT 14
- Can not export to WebGL
- Domain Reload support
- JsonSerializationException: Unable to deserialize instance of 'BgDataMessage' for iOS on device.. HOT 7
- Schema Backward Compatibility not working as expected HOT 2
- colyseus-unity-sdk-0.14.20 schema-codegen bug. HOT 3
- Problems with lobbyRoom and ColyseusRoomAvailable. HOT 4
- colyseus-unity-sdk-0.14.15 ->18 Example Error. HOT 2
- schema lost in reconnection situation HOT 2
- The 'onMesssage' in file 'Assets/Colyseus/Runtime/WebSocket/WebSocket.jslib' is wrong
- Colyseus.MatchMakeException: Unexpected end of JSON input HOT 2
- ColyseusManager destroy game object unexpected or have multiple instance when change scene HOT 3
- Unable to Join GameRoom after migrating to 0.15.3 Version Unity HOT 3
- Make OnJoin private
- OnStateChange Called When Current Value And Previous Values are same HOT 4
- about 0.15 state.player.listen("field", (value)) HOT 3
- ColyseusRoom.OnMessage<> throws exception if the sessionId exists
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from colyseus-unity-sdk.