Git Product home page Git Product logo

Comments (7)

aloani20 avatar aloani20 commented on June 18, 2024 1

lick = like. so happy it worked

from colyseus-unity-sdk.

endel avatar endel commented on June 18, 2024

The problem is exactly on this check: https://github.com/gamestdio/colyseus-unity3d/blob/f08f47d5758e0228f3e0e91b6a1b50dd1fe7aa7f/Assets/Plugins/Colyseus/DeltaListener/Compare.cs#L61-L65

It returns true for string changes, whereas it should return false and perform a "replace" operation: https://github.com/gamestdio/colyseus-unity3d/blob/f08f47d5758e0228f3e0e91b6a1b50dd1fe7aa7f/Assets/Plugins/Colyseus/DeltaListener/Compare.cs#L87-L99

from colyseus-unity-sdk.

endel avatar endel commented on June 18, 2024

Just added a failing test scenario confirming the issue: f08f47d

from colyseus-unity-sdk.

aloani20 avatar aloani20 commented on June 18, 2024

thanks endel.

from colyseus-unity-sdk.

aloani20 avatar aloani20 commented on June 18, 2024

dear endel
I checked it. It gave the same result as before. could you check it again please.

from colyseus-unity-sdk.

endel avatar endel commented on June 18, 2024

Hey @aloani20, are you sure you checked the right version? Here's how the updated Compare.cs looks like: https://github.com/gamestdio/colyseus-unity3d/blob/0.5.6/Assets/Plugins/Colyseus/DeltaListener/Compare.cs#L64-L68

from colyseus-unity-sdk.

aloani20 avatar aloani20 commented on June 18, 2024

thanks Endel woks lick a charm.

from colyseus-unity-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.