libUseful mistakes Mac getxattr for Linux getxattr about libuseful HOT 4 CLOSED

thanks for reporting this. I thought I'd already fixed this one, but I must not have been able to figure it out. Do you have any insight into autoconf, and how I might catch this? I've always found autoconf to be like something Serverus Snape would teach.

hmm... maybe I can just check for osx at compile time? I did think I was doing that.

from libuseful.

Yeah, I think checking it in autoconf is going to be... thorny? I have about the same experiences with trying to make autoconf checks like that more complex.

I think scoping the check to #ifdef __linux__ would be more appropriate than checking for OS X; since it's a non-POSIX API, any other functions by the same name in other non-OS X OSs are probably also going to end up being incompatible.

from libuseful.

I've discovered there's an #ifdef APPLE, which I'm hoping will fix it. It's passing on travis-ci, but then it was before too. It's in the 4.23 release.

I tend to find autoconf is, to paraphrase Churchill, the worst build system there is, except for all the other ones I've seen.

Thanks again for reporting this.

from libuseful.

Thanks! I caught a handful of very minor issues with that commit, so I opened #2 to fix that.

from libuseful.