Git Product home page Git Product logo

Comments (4)

collinsmith avatar collinsmith commented on May 20, 2024

I spoke too soon. The issue appears in all acts, just much less noticable. aside from the background color not matching black like on desktop, this looks like an index is mismatched. need to look into the specific index and pixel shader

from riiablo.

collinsmith avatar collinsmith commented on May 20, 2024

Experimented using different blend mode and still got the same behavior.

from riiablo.

collinsmith avatar collinsmith commented on May 20, 2024

Playing with the palettes directly shows that this appears to be an issue with index 254 across at least act 1 and 3 (the only ones that I've tested). The working assumption is that for some reason this value gets rounded up to index 255, which is white. Going to play around with texture filtering and wrapping and if need be, clamping the 0.5f offset to prevent a possible unwanted rounding because 254 is close enough to 2^8 (256).

from riiablo.

collinsmith avatar collinsmith commented on May 20, 2024

Texture filtering looks alright -- I assigned the renders to the default values. My guess is that this is caused by some rounding issue relating to the pixel (frag) shader for the upper index. This will require more extensive investigation to a more permanent suitable fix, however in the meantime I've added a workaround to the shader to translate index 255 to index 254 which has had no apparent side effects (have not tested or looked for legitimate uses of index 255). I'm uncomfortable with this fix until I can figure out why this is happening in only newest version of android.

Index 255 is the same in every included palette (0xFFFFFF). I'd like to look through all included files and see if it's ever actually used -- many palettes with a white color seem to define it elsewhere in their table -- so it may just not ever be used, or it has some other meaning like index 0, or acts as a signature/terminator for palettes. In any case, this appears to be suitable workaround until this can be explorer further.

from riiablo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.