"version" accessor in audited models clobbers "version" column (if present) about audited HOT 7 CLOSED

@kennethkalmer, would you like us to take a stab at this? We would really like the ability to change the name of the :version attr_accessor on our models to get rid of our monkey patches. Let us know if you'd have time to accept our PR before we spend time on it. Thanks.

from audited.

Curious as to what your workaround was? I am running into the same thing.

from audited.

My workaround is to define virtual attribute "version" in the to be audited model:

  def version=(value)
    write_attribute(:version, value)
  end

  def version
    read_attribute(:version)
  end

from audited.

I'll take a stab at this. The general assumption was that you wouldn't have a separate version column in the model you're auditing since the versioning is delegated to acts_as_audited.

from audited.

I had the version column in a model before I wanted to apply acts_as_audited. I could rename it but the above workaround could avoid code changes in many places. In the same time, I wonder if it's better not to define extra methods on a model if possible.

from audited.

I've just run into exactly the same issue. Took me a while to work out why my application stopped working after adding auditing to one of my models, but this was it - the version method that audited added returns nil, which breaks things.

👍 for not defining extra methods on the model!

from audited.

Hi there! We’re doing some open source maintenance work and closing old issues. If you would still like this PR to be merged in, please re-open it by 2-weeks-from-today. Thanks!

from audited.