Comments (2)
Awesome, thanks a lot for this feedbacks! I'll try to give it a shot ASAP, not sure exactly when though (hopefully in the next few months).
And definitely +1 to throwing if not supported :-)
from assemblyscript-regex.
Thanks for raising this. The problem is that the library currently doesn't support start or end of string assertions within alternations.
see the spec test here: https://github.com/ColinEberhardt/assemblyscript-regex/blob/main/assembly/__spec_tests__/generated.spec.ts#L2205
The current implementation assumes that these occur at the start or end of the regex string: https://github.com/ColinEberhardt/assemblyscript-regex/blob/main/assembly/regexp.ts#L126-L132
Happy to give it a shot, if you have any hint where to start looking it would probably save me a lot of time :-)
That would be great! The assertion logic is applied in this function: https://github.com/ColinEberhardt/assemblyscript-regex/blob/main/assembly/regexp.ts#L153-L222
As an aside, it would probably be useful for this library to throw an error if you use a regex that has features that are not supported yet.
from assemblyscript-regex.
Related Issues (20)
- Feedback on "createRegExp" TODO comment
- Move to semantic versioning ... soon HOT 1
- Strategy for ensuring functional correctness? HOT 4
- Explore the use of as-pect HOT 3
- Add JavaScript's RegExp as baseline for benchmarks HOT 1
- Run the unit tests in TypeScript mode as well as WebAssembly / AssemblyScript HOT 1
- Should not return captured values for non-matching alternations HOT 2
- Help with the testing effort HOT 3
- Potential memory leak? HOT 2
- Run benchmark tests on node v15 HOT 3
- NFA includes some states that are redundant HOT 1
- capture groups with quantifiers should not be repeated in the returned results HOT 1
- Improve better error handling for malformed regex expressions
- Fail more visibly for unsupported features
- capture groups are in wrong order HOT 3
- Prettier does not support function decorators
- Add CI tests HOT 1
- Add NFA -> DFA transformation + optimizations in this domain HOT 6
- Terminology confusion: character set <=> character class HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from assemblyscript-regex.