Version Assemblies task no longer does multiline matches (due to update to sed in shelljs) about cols-agent-tasks HOT 4 CLOSED

Thanks for reporting this @ColinDabritzViewpoint - I'll take a look at this. Including a multi-line option sounds like a good solution.

from cols-agent-tasks.

Hi @ColinDabritzViewpoint I'm not sure how the sh.sed could ever have worked, but I could repro and couldn't get it to work. I eventually used string.replace instead of the sh.sed call and it seems to be working. Let me know if the 1.1.119 version of the extension pack (the task version should be 2.2.119) works for you.

from cols-agent-tasks.

See this change set in sh.sed:
shelljs/shelljs@1ee696d

The previous implementation was:
var result = fs.readFileSync(file, 'utf8').replace(regex, replacement);

So string.replace is apparently how it used to work in 0.5.3. The newer version starts breaking out lines, and changes the behavior we depended on.

We're on VSTS, and it looks like 2.x has updated for us, we're seeing version 2.2.119

2017-04-26T16:37:36.4839826Z ==============================================================================
2017-04-26T16:37:36.4839826Z Task         : Version Assemblies
2017-04-26T16:37:36.4839826Z Description  : Updates the version number of the assemblies to match the build number
2017-04-26T16:37:36.4839826Z Version      : 2.2.119
2017-04-26T16:37:36.4839826Z Author       : Colin Dembovsky (colinsalmcorner.com)
2017-04-26T16:37:36.4839826Z Help         : [More Information](https://github.com/colindembovsky/cols-agent-tasks/tree/master/Tasks/VersionAssemblies)
2017-04-26T16:37:36.4839826Z ==============================================================================

I was able to run our existing work-around build as well as a new build which reverted the work around (and would have failed previously).

Both versions have gotten the correct replacements.

This preserves our existing behavior dependency in 2.x.

Thank you for your curation of this excellent set of tasks, and your quick responses, it is greatly appreciated!

I think we're good to go, and this issue is resolved.

from cols-agent-tasks.

Thanks @ColinDabritzViewpoint - I noticed the line break-out in shelljs, and stole the string.replace idea from the previous version :-). Glad you're unstuck!

from cols-agent-tasks.