Here's a full tran (after installing using the steps in <a class="issue-link js-

Python segfault crashes if a initialize() method throws an exception about sqlite-vtfunc HOT 4 CLOSED

coleifer commented on August 17, 2024

Python segfault crashes if a initialize() method throws an exception

from sqlite-vtfunc.

Comments (4)

simonw commented on August 17, 2024

It looks like this is the code which is supposed to catch these kinds of exceptions:

sqlite-vtfunc/vtfunc.pyx

Lines 264 to 269 in 23ddc21

 try: 

 result = table_func.iterate(pCur.idx) 

 except StopIteration: 

 pCur.stopped = True 

 except: 

 return SQLITE_ERROR

I'm not sure why return SQLITE_ERROR there is causing a segfault. Maybe that catch block should set pCur.stopped = True as well?

from sqlite-vtfunc.

simonw commented on August 17, 2024

Oh hang on... the clue is in the traceback: Exception ignored in: 'vtfunc.pwFilter'

Makes sense. The exception is being triggered in the initialize()' method. And it looks like there's no try/except around the call to that from the pwFilter` function:

sqlite-vtfunc/vtfunc.pyx

Lines 371 to 372 in 23ddc21

 table_func.initialize(**query) 

 pCur.stopped = False

from sqlite-vtfunc.

coleifer commented on August 17, 2024

Thanks for reporting, fixed.

from sqlite-vtfunc.

simonw commented on August 17, 2024

I just tested this against the new 0.3.3 release from PyPI and it worked! Thanks for the fix.

>>> curs = conn.execute('SELECT * FROM scraper(?) ORDER BY length(description) DESC  LIMIT 3', ('https://news.ycombinator.com/',))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
sqlite3.OperationalError: SQL logic error

from sqlite-vtfunc.

Recommend Projects