Git Product home page Git Product logo

Comments (5)

olivierbossel avatar olivierbossel commented on August 21, 2024

Hi there,
First thanks for your interest in gridle and thanks for your feedback.
I'm not aware of dart sass so I cannot tells you more on that for now. I have to make tests etc...
I can encourage you to use node-sass as a replacement cause It works very well and is very performant.
I will investigate on dart sass but I can't promise you that I will make big changes to gridle for that. Will see

from gridle.

Neograph734 avatar Neograph734 commented on August 21, 2024

Hi Olivier,

So far ruby sass has been working pretty well for me. Dart-sass was new to me as well, but appears to be the go-to direction. The sass site links to it as standalone installation, and npm and chocolatery installation methods also appear to be pulling from some dart image.
My issues above were specifically with the standalone installation for Windows, but it could be that these other installation methods have the same effect.

You can read about it on the sass blog: http://sass.logdown.com/posts/7081811

In the meantime I will see if I can get node-sass up and running (thanks for the suggestion :) ).

from gridle.

Windvis avatar Windvis commented on August 21, 2024

Since dart-sass is the new reference implementation, griddle should be made compatible with it, in my opinion. We use griddle in some of our projects, and we can't modernise our build tooling because of this problem.

Maybe you can add a warning in the readme about the dart-sass incompatibility for now?

from gridle.

olivierbossel avatar olivierbossel commented on August 21, 2024

The issue here is that Gridle make heavy use on silent classes that are scoped (initialized) inside a media query and dart sass seems to doesn't care about that and set these silent classes in the root scope. Then when I try to extend one of these silent classes from inside a media query, the error listed above pops up. As this is a core principle of Gridlev3, it will be difficult to rearrange the code to make it work with these sass implementations.
By the way, I will release Gridle v4 (in release candidate for now) soon. It will be a little bit different and a lot simpler so I hope this will be a kind of answer to your issues

from gridle.

rastapopougros avatar rastapopougros commented on August 21, 2024

Hello, just to add a bit more information and a little question : now in 2022, "node-sass" is explicitly marked as deprecated, so the compiler to use is de facto "sass" (means dart sass) who is the one following the standard (for ex math.div instead of "/" as described https://sass-lang.com/documentation/breaking-changes/slash-div). Many frameworks already changed and only work with "sass" and never with "node-sass". So this is not an option at all.

As a consequence, I understand that the only solution is to use Gridle 4 ? (which compiles ok with "sass" ?)

But what if we have production code with Gridle 3, and absolutely can't change all the architecture to use Gridle 4 and just updated npm/gulp stack and… all broken 'cause new versions can't compile Gridle 3 ? :(

I will try to downgrade all versions of the stack gulp etc, until all compile again…

from gridle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.