Comments (29)
@SaumyaSingh1 You have to mark the sections of course content that are free, I guess.
Also, sorry, I won't be able to work on this issue anymore.
from cbonlineapp.
Go ahead
from cbonlineapp.
I would like to solve this issue
from cbonlineapp.
But free label is already marked here.
Am I right ? Please guide .
from cbonlineapp.
Add it to course individual sections
from cbonlineapp.
Free label in few sections , is it something like this ...
from cbonlineapp.
Yes exactly like this
from cbonlineapp.
so, upto how many sections should we mark free label ? And are we supposed to do this in all the courses ?
from cbonlineapp.
For all the sections which are not premium and obviously yes for all the courses
from cbonlineapp.
okay :)
from cbonlineapp.
@aggarwalpulkit596 I have added the free label . looks like this ..
But right now the label is for all sections . Need sometime to make it confined to the sections which are not premium :)
from cbonlineapp.
Does it good to you ? I don't think so make design similar to website
from cbonlineapp.
Okay i will make design similar to the website .
from cbonlineapp.
@aggarwalpulkit596 From where can we know that which courses are free and which are not??
from cbonlineapp.
I am also at this stage and now i just want to know that from where i can get the data that which courses are free and which are not????
from cbonlineapp.
I did it.
Is it alright or @aggarwalpulkit596 you need more modificitaions??
Its working fine for all the courses.
from cbonlineapp.
Its all set now looking exactly like the website can i send a pr now??? @aggarwalpulkit596
from cbonlineapp.
If @SaumyaSingh1 is okay with this you can send a PR @shubhamofbce
from cbonlineapp.
@aggarwalpulkit596 please review
from cbonlineapp.
@shubhamofbce i told you @SaumyaSingh1 asked it first if she doesn't make a pr by tomorrow I'll your pr
from cbonlineapp.
But i asked to work on this first , You can see the comments from the begining. I asked two days ago she commented today.
from cbonlineapp.
@SaumyaSingh1 i guess it's okay then
from cbonlineapp.
@aggarwalpulkit596 Because of my exams i was not able to complete the task . But I have done half of the work .
Issue is still open ! are we still supposed to resolve same problem.
Thanks for the guidance @aggarwalpulkit596
from cbonlineapp.
@SaumyaSingh1 yeah you can still work on this follow the design which @shubhamofbce used but his method was incorrect so i had to revert that
from cbonlineapp.
Okay
from cbonlineapp.
Did @SaumyaSingh1 resolved the issue or is it still open??? @aggarwalpulkit596
from cbonlineapp.
It is still open
from cbonlineapp.
@aggarwalpulkit596 I made a pr with proper logic this time do check it.
from cbonlineapp.
@aggarwalpulkit596 #209 has no conflicts and got all tests passed too. please review for one last time.
from cbonlineapp.
Related Issues (20)
- Crash when clicked Spin N Win HOT 1
- Add support to save downloads in SD Card HOT 5
- Download button not working after downloading video HOT 3
- Add Feature: On Tap on the Referral code Copy Referral Code as a Text HOT 2
- Bug report : Issue in "Delete all Downloads" Confirmation Prompt. HOT 3
- Feature request: prev and next button in the video player. HOT 5
- Feature request: Auto Play Next mode in the video player. HOT 4
- Bug Report : no way to clear answered option of MCQ, if we not want to answer this. HOT 4
- Bug Report : MCQ with long option not visible completely. HOT 6
- Feature Request : Auto-Hide Controls in Video Player. HOT 9
- Open all type of bookmarks other than Videos HOT 1
- Fix lint issues throughout the project HOT 6
- Course preview YouTube player showing error HOT 2
- Feature request : Touch Lock Option while video playing. HOT 3
- Feature Request: Touch Sensetive volume and brightness control feature. HOT 3
- Feature request: logIn with email placeholder should be email/username. HOT 2
- ViewPager bottom dots are not updating HOT 4
- Remove HardCoded size as 3 in intro screen. HOT 1
- Add infinite scrolling in the intro screen. HOT 5
- Add Per Video Feedback Component HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cbonlineapp.