Git Product home page Git Product logo

Comments (6)

trichoplax avatar trichoplax commented on August 16, 2024

Would a follower of a thread expect to be notified that it has been archived? As a thread follower I would want to hear about any new comments, but I wouldn't personally expect to hear about the prevention of new comments.

from qpixel.

cellio avatar cellio commented on August 16, 2024

When considering notifications, one question we should ask is: what can the notified person do in response to this notification? For new activity, the person probably wants to go read it, edit suggestions need review, and for pings, a response has been requested. But we don't notify for deleted comments or posts, for example.

Should we notify for a locked or archived thread? Maybe for archiving, as that's a "resolved" signal. Locking is usually a calming action (arguments getting out of control or the like), and notifications might stir things up again.

from qpixel.

ws909 avatar ws909 commented on August 16, 2024

Would a follower of a thread expect to be notified that it has been archived? As a thread follower I would want to hear about any new comments, but I wouldn't personally expect to hear about the prevention of new comments.

@trichoplax Yes; see this Meta Q/A: Notifying each other that a commented-on issue is resolved, to produce fewer comments rather than more.

The problem, however, is that notifications should only be delivered for resolved issues like the mentioned ones: unclear typos, etc. Delivering notifications for archiving discussion threads, not so much.

from qpixel.

trichoplax avatar trichoplax commented on August 16, 2024

@ws909 The problem they are trying to solve there is that you cannot let someone know that their comment is ready to delete without also leaving a comment of your own, which they then have to let you know you can delete, in an endless cycle.

With thread archiving, the comments do not need to be deleted, so the commenters do not need to notify each other. In some cases one of the commenters may wish to notify the other, but in that specific case they can simply add a comment before archiving. This way thread followers are only notified when the person archiving the thread explicitly chooses to notify them. Personally I would prefer this rather than being notified every time a thread I'm following is archived.

If some people expect that archiving will notify thread followers, and other people expect that it will not, maybe we could make it explicit to the person archiving the thread. There could be a dialogue box when you click "Archive" that has a checkbox saying "Notify thread followers" that defaults to not ticked. Ticking the box could provide a text input allowing an optional message to be entered. This way, thread followers either do not get notified, or in cases where the thread archiver wishes to notify them, there is a reminder that this is an option.

from qpixel.

ws909 avatar ws909 commented on August 16, 2024

@trichoplax

he problem they are trying to solve there is that you cannot let someone know that their comment is ready to delete without also leaving a comment of your own, which they then have to let you know you can delete, in an endless cycle.

No, then you've misunderstood. As I explained in my answer, the reason I left a new comment, was to notify Karl not about his comment being ready to be deleted, but that the issue had been resolved. There's no mention of any endless cycles anywhere there. The current best way to have those comments deleted, was to flag as "no longer needed". Both me and Karl come from SE, so that's the solution we're used to, and neither of us considered that comment threads present an alternative solution to this problem, which I agree seems better suited, although not without its own issues. That's what this GH issue comes from; resolving an issue, and marking it resolved by archiving the comment thread, and then notifying the users involved, that it's been resolved. Overall, this is more complicated than what seems necessary at first sight, but if Karl only wanted to point out a typo, he should've just suggested an edit to my post. He wasn't sure about it, and potentially misunderstood my post, which is why I wanted to notify him once it was resolved.

With thread archiving, the comments do not need to be deleted, so the commenters do not need to notify each other

So, well, in this particular case, and likely more to come, it is/was needed.

from qpixel.

trichoplax avatar trichoplax commented on August 16, 2024

I understand the specific case you describe in your answer. The case I was referring to as an endless cycle is the "no, you hang up" routine mentioned in the question. I understand that both cases need to be addressed.

The fact that there are multiple cases with different requirements is why I suggest that always notifying thread followers of thread archiving will mean unwanted notifications for some of the cases.

In the case where the only reason for commenting is to let another user know that they can delete their comment now, archiving removes the need to comment, and no notification is needed.

In the case where a user wants to let another user know that a query is resolved, they can add a comment to say so, immediately before archiving the thread. There is still no automated notification required.

I added the final paragraph of my previous comment in case there is a concern that some users may expect the act of archiving to notify thread followers.

from qpixel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.