Git Product home page Git Product logo

Comments (5)

luap42 avatar luap42 commented on September 15, 2024

I'll review this later/tomorrow and fix some of these things.

However, at least the last point is not a problem:

  1. If the modal body exceeds that height, scroll bars appear.
  2. On mobile, the modal body spans the whole height, due to this rule:
    flex-grow: 1;

from co-design.

luap42 avatar luap42 commented on September 15, 2024

I don't think, the hard-coded values will lead to a problem with responsiveness. CD is fully responsive AFAIK and AFAICT.

I'll review the decision to use pixels rather than ems, however that might take some time and is rather low priority (at least for me - feel free to open a PR) unless one can demonstrate actual problems with it (with screenshots).

from co-design.

appgurueu avatar appgurueu commented on September 15, 2024

Hardcoded values might pose issues regarding code quality.

I should've probably opened a separate issue; it's about the pixels. Pixels and other absolute units are per definition non-responsive. Which means a user on a 4k display will have the same button shadow as somebody on his 640p Raspi display. And that's non-responsive.

As the W3 schools article I quoted states:

The absolute length units are fixed and a length expressed in any of these will appear as exactly that size. Absolute length units are not recommended for use on screen, because screen sizes vary so much. However, they can be used if the output medium is known, such as for print layout.

Wth an exception, however:

Pixels (px) are relative to the viewing device. For low-dpi devices, 1px is one device pixel (dot) of the display. For printers and high resolution screens 1px implies multiple device pixels.

from co-design.

luap42 avatar luap42 commented on September 15, 2024

This is being worked on.

from co-design.

luap42 avatar luap42 commented on September 15, 2024

All values are now set in the _config.scss, except for those, that cannot be changed while maintaining the basic design idea.

from co-design.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.