Comments (5)
I'll review this later/tomorrow and fix some of these things.
However, at least the last point is not a problem:
- If the modal body exceeds that height, scroll bars appear.
- On mobile, the modal body spans the whole height, due to this rule:
Line 115 in c969990
from co-design.
I don't think, the hard-coded values will lead to a problem with responsiveness. CD is fully responsive AFAIK and AFAICT.
I'll review the decision to use pixels rather than ems, however that might take some time and is rather low priority (at least for me - feel free to open a PR) unless one can demonstrate actual problems with it (with screenshots).
from co-design.
Hardcoded values might pose issues regarding code quality.
I should've probably opened a separate issue; it's about the pixels. Pixels and other absolute units are per definition non-responsive. Which means a user on a 4k display will have the same button shadow as somebody on his 640p Raspi display. And that's non-responsive.
As the W3 schools article I quoted states:
The absolute length units are fixed and a length expressed in any of these will appear as exactly that size. Absolute length units are not recommended for use on screen, because screen sizes vary so much. However, they can be used if the output medium is known, such as for print layout.
Wth an exception, however:
Pixels (px) are relative to the viewing device. For low-dpi devices, 1px is one device pixel (dot) of the display. For printers and high resolution screens 1px implies multiple device pixels.
from co-design.
This is being worked on.
from co-design.
All values are now set in the _config.scss
, except for those, that cannot be changed while maintaining the basic design idea.
from co-design.
Related Issues (20)
- Make code blocks bigger vertically HOT 11
- Make typing long comments easier HOT 1
- Tools button isn't clickable for some users (Chrome) HOT 1
- Add different font stacks for different languages
- Fix the co-design package versions on GitHub HOT 3
- allow header slide and droppanel to close on click outside
- dark theme for Codidact HOT 2
- Deprecation Warning: Using / for division is deprecated and will be removed in Dart Sass 2.0.0. HOT 1
- Some syntax error in CoDesign HOT 6
- Allow input textboxes to be resized
- Should visited links be a different color?
- Modals sometimes won't open (rather they open and immediately close) HOT 1
- H1 and H2 are too close in size
- Push new version to fix drop-down problem HOT 4
- Improve scrolling for code blocks on phones HOT 4
- Build instructions differ between readme and guide HOT 3
- Trying to build docs gives Eleventy error
- Needs design analysis: can we improve highlighting in category bar? HOT 3
- Text boxes in post editor have inconsistent borders, causing confusion
- Input elements lack consistency. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from co-design.