[Feature] List Series about event_member_management HOT 6 CLOSED

Hi @TheBeege, thanks for creating a such nice project!

• Can I work on this issue? If it is okay, do you want me to add any additional columns for the Series Model other than the columns mentioned in the seed data up SQL file?
• Also, in the Event Model, should I keep the type of series as any or should I change it as number[]?
• Lastly, how should I add test cases?

from event_member_management.

Hey @kzkaneoka ! Yeah, I'm looking forward to working together with people on it. Thanks for helping!

• Yes, I'll assign it to you once I figure out how. Most of my experience is with Jira and Gitlab, so I'll be learning, too. Feel free to add any columns you may think would be needed, and update the migration file as necessary. We'll lock down migrations once I get the system setup; until then, feel free to edit as necessary.
• In the Event Model, you'll want to change series to a list of SeriesModel objects once you've defined them.
• I'm working on tests now. I'm having a bit of trouble with mocking, but I hope to have some examples up today or tomorrow.
  Let me know if you have more questions!

from event_member_management.

Hi @TheBeege, thanks for assigning! Two more questions :)

• Which branch should I create PR for? master or feature/infra?
• Git shows diff for package-lock.json even I just did npm install. Should I include/exclude package-lock.json in PR?

Thanks!

from event_member_management.

Hey @kzkaneoka .

• Please create the PR for master.
• Huh, strange. It may have been a mistake on my part. Please include it. If there is an issue, I'll fix it.

Thanks!

from event_member_management.

Hi @TheBeege,

I created the above PR. Please review it when you have time.

Npm docs tells why npm install overwrites package-lock.json and also says:

It is highly recommended you commit the generated package lock to source control

However, I didn't include package-lock.json in this PR because git diff showed thousands of line deletions in package-lock.json. Instead, I used npm ci to install the modules where no diff happened in package-lock.json.

Thanks!

from event_member_management.

Excellently done! Thank you @kzkaneoka !

I'll need to rework some things due to a major change I made, but I think it will be easier. I'll message you once I get my changes merged.

from event_member_management.