Git Product home page Git Product logo

Comments (8)

codekitchen avatar codekitchen commented on July 26, 2024 1

I just upgraded and I'm able to repro as well. I don't see anything that jumps out to me in the Changelog, so I'm adding some more logging to try and track it down.

from dinghy-http-proxy.

codekitchen avatar codekitchen commented on July 26, 2024

Interesting that running that command manually makes it work again, since it's the same command the join-networks trigger is supposed to run. I wonder if the hook no longer getting called on each container start/stop. Do you see any errors in docker logs dinghy_http_proxy?

from dinghy-http-proxy.

tierra avatar tierra commented on July 26, 2024

I can confirm seeing this issue pop up at Instructure too. The proxy logs show new containers being added and removed from nginx vhosts just fine, so it seems like those events are still working fine.

from dinghy-http-proxy.

htuscher avatar htuscher commented on July 26, 2024

from dinghy-http-proxy.

codekitchen avatar codekitchen commented on July 26, 2024

Found the relevant change: moby/moby#30673

This changes the API response format in a breaking way. It preserves the old format when specifying you want to use a previous version of the API, but the way I'm using the go docker client, it'll always use the newest version, so it breaks.

I'll just update the code to use individual network inspect calls, since that'll still work on older versions of docker too.

from dinghy-http-proxy.

codekitchen avatar codekitchen commented on July 26, 2024

OK this is fixed now, you can force an update with docker pull codekitchen/dinghy-http-proxy:2.5 and then dinghy restart. I'll push out a new version of Dinghy later.

from dinghy-http-proxy.

tierra avatar tierra commented on July 26, 2024

Thanks for tracking that down and fixing it!

from dinghy-http-proxy.

htuscher avatar htuscher commented on July 26, 2024

Awesome. Thanks for the quick resolution

from dinghy-http-proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.