Network auto joining doesn't work since Docker 17.04 about dinghy-http-proxy HOT 8 CLOSED

I just upgraded and I'm able to repro as well. I don't see anything that jumps out to me in the Changelog, so I'm adding some more logging to try and track it down.

from dinghy-http-proxy.

Interesting that running that command manually makes it work again, since it's the same command the join-networks trigger is supposed to run. I wonder if the hook no longer getting called on each container start/stop. Do you see any errors in docker logs dinghy_http_proxy?

from dinghy-http-proxy.

I can confirm seeing this issue pop up at Instructure too. The proxy logs show new containers being added and removed from nginx vhosts just fine, so it seems like those events are still working fine.

from dinghy-http-proxy.

from dinghy-http-proxy.

Found the relevant change: moby/moby#30673

This changes the API response format in a breaking way. It preserves the old format when specifying you want to use a previous version of the API, but the way I'm using the go docker client, it'll always use the newest version, so it breaks.

I'll just update the code to use individual network inspect calls, since that'll still work on older versions of docker too.

from dinghy-http-proxy.

OK this is fixed now, you can force an update with docker pull codekitchen/dinghy-http-proxy:2.5 and then dinghy restart. I'll push out a new version of Dinghy later.

from dinghy-http-proxy.

Thanks for tracking that down and fixing it!

from dinghy-http-proxy.

Awesome. Thanks for the quick resolution

from dinghy-http-proxy.