Git Product home page Git Product logo

Comments (6)

bkeepers avatar bkeepers commented on July 16, 2024

It would be nice if the entire response object was available. Embedded resources could just use the response from the parent resource.

from hyperclient.

txus avatar txus commented on July 16, 2024

@bkeepers yeah, having the entire response object separated seems like a good idea. Are you up for implementing it?

from hyperclient.

benhamill avatar benhamill commented on July 16, 2024

+1 on keeping the whole response object around. And proxying various methods to is (like success? and status). If no one minds, I may turn this Issue into a Pull Request so that people have something concrete to poke at.

Also, right now, if someone sends back no body (say, for a 404 or a 204), .resource blows up trying to call [] on nil, which seems related.

from hyperclient.

benhamill avatar benhamill commented on July 16, 2024

Well, I made a branch about this: https://github.com/benhamill/hyperclient/compare/keep_response_object_in_resource

For some reason, though, I can't seem to attach the code to this issue. It keeps giving me this message:

Error creating pull request: Not Allowed (HTTP 405)

I'll try again later on.

from hyperclient.

benhamill avatar benhamill commented on July 16, 2024

OK. Well, see #46 for a PR on this topic.

from hyperclient.

oriolgual avatar oriolgual commented on July 16, 2024

Closed by #46

from hyperclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.