Add ON-EXIT to indentation rules in linter.js about vscode-rpgle HOT 7 CLOSED

Would those rules always give a warning about ON-EXIT not being indented? If so, I think there should be an option about ON-EXIT.

Me, I think ON-EXIT should be at the same indentation level as DCL-PROC and END-PROC,

from vscode-rpgle.

@JamesBrianHill

Feel free to do either of these:

• a PR to add this line. Though a new PR will also require you to make a test case for this too.
• Please share a code snippet that used ON-EXIT and I can do the change and create a valid test.

Thanks!
Liam

from vscode-rpgle.

Code snippet:

//--------------------------------------------------------------------------------------------------
// Append a single quote. This procedure exists to make other code more readable.
//--------------------------------------------------------------------------------------------------
DCL-PROC Q;
  DCL-PI Q VARCHAR(2048);
    in_str VARCHAR(2048) CONST OPTIONS(*TRIM);
  END-PI;

  DCL-C C_QUOTE '''';
  DCL-S is_abend IND INZ(*OFF);
  DCL-S return_str LIKE(in_str);

  return_str = %TRIM(C_QUOTE + in_str + C_QUOTE);
  RETURN return_str;

  ON-EXIT is_abend;
    IF is_abend;
      return_str = 'Liam does great work!';
    ENDIF;
END-PROC Q;

from vscode-rpgle.

Looking good. Will be out in an upcoming release.

from vscode-rpgle.

from vscode-rpgle.

But for sure, code following ON-EXIT should be indented one level higher than ON-EXIT.

from vscode-rpgle.

@bmorris1 Maybe so. I actually like the way @JamesBrianHill provided it because it is part of that procedure and my brain easily associates it when the indentation is higher than the end-proc.

from vscode-rpgle.