Change App logo image size requirement about codeforamerica.org-archive HOT 7 CLOSED

I just pushed this which removes the width from the CSS: 03c861f – does that fix it?

Let me know how they look after you've got a load in there, I want to get the balance right between them being roughly consistent sizes but also accommodating for particularly wide or tall logos.

from codeforamerica.org-archive.

Looks like; just figuring out the changes to see if I understand them. Working backwards…

1. Should I remove layout-col in the apps sections throughout, based on 51a3106?
2. You’re using a new teaser-image class in 03c861f; should I use it for the apps sections?
3. The pop-rockets are no longer separate elements as of 4d55d66, but are now folded in to a new badge-rocket class. Should I ditch all the pop-rocket elements?
4. I have some new things to add to the head as of 4d55d66: a viewport and some feature-detection JS. Could that SVG detection happen in global.js instead, where it looks like the Javascript detection is also happening?

from codeforamerica.org-archive.

1. Yes, that was some old code.
2. No, that's a mistake, sorry – I copied the images across from the teasers and forgot they had classes. It doesn't need them. I'll update that pattern.
3. Yes, Jon's designs only have rockets in the badges, and I felt weird that they were in the HTML because they're decoration. If you do want different images in the circles, that can still be done with an additional class on the badge-heading (like I'm doing for the different colors).
4. I think it can, the reason I put it in the head is because I wanted that SVG detection to happen really early so you can't see it load in the pngs then replace them with SVGs, but let's try it in the main javascript file and see if it's actually a problem.

from codeforamerica.org-archive.

1. Okay!
2. I’ll leave it all as-is, then.
3. I like this new way of doing it as well.
4. I'll wait to integrate this part.

from codeforamerica.org-archive.

1. Done in 6d85761.
2. —
3. Done in 49762f3.
4. Waiting to see if the change could be in global.js.

The big merge was in 12e0653.

from codeforamerica.org-archive.

Moved SVG and JS detection to global.js in commit 797af57

I have added some more content to the profile pattern, but no new markup (just some additional icons).

from codeforamerica.org-archive.

Picked those up in 53378ae.

from codeforamerica.org-archive.