Boolean saveCallbacks in DcaAjaxOperationsListener with strict database about contao-haste HOT 8 CLOSED

It's already a boolean. Why does it try to save an empty string?

from contao-haste.

I need to debug that again today - it was to late this night ;-)

from contao-haste.

@aschempp @Toflar should we type cast the value based on its SQL definition before it is even evaluated and stored in the database? The single checkbox value in Contao can return a lot of stuff:

• true / false
• '1' / '0'
• '1' / ''
• 1 / 0

Or shall we have an internal mapper that converts the values to boolean for evaluation, and sets the correct type right before updating the database?

from contao-haste.

Casting the value to a string for an empty check ('' === (string) $value) together with Widget::getEmptyValueByFieldType() should be your friend. See https://github.com/contao/contao/blob/5.x/core-bundle/contao/drivers/DC_Table.php#L3215-L3231.

from contao-haste.

Thanks @Toflar 🧡 that's what I also figured out while analysis.
I startet a PR. But I need to test it with my project in the next few days!

from contao-haste.

Unfortunately the getEmptyValueByFieldType is not enough or better say in my case it is already false because of the callback but the database update

Do we need some special cast for doctrine call?

from contao-haste.

Why is your value an empty string if it expects a boolean?

from contao-haste.

Do we need some special cast for doctrine call?

You need to specify the field type otherwise Doctrine will cast everything to string (which is then an empty string for false).

from contao-haste.