Comments (13)
@thomasrockhu-codecov we're getting that over at eslint-plugin-jest
- I've been trying a few things to see if I can get it unblocked and/or more information out of it so the latest failings might not be the ones you want (though they are at time of post), but here's a few runs that have the failing:
- https://github.com/jest-community/eslint-plugin-jest/actions/runs/8838551117/job/24269972063
- https://github.com/jest-community/eslint-plugin-jest/actions/runs/8838551117/job/24269972435
- https://github.com/jest-community/eslint-plugin-jest/actions/runs/8838690559/job/24270435998
- https://github.com/jest-community/eslint-plugin-jest/actions/runs/8838690559/job/24270436821
Note the last couple are using v4.1.1 specifically which is before OIDC support was landed - technically I can't verify this isn't user error as I don't have permissions to set secrets on the repository, but even if it is it seems like a very confusing error message to get if the problem is the codecov token is plain wrong.
(I have tried giving a known bad token and gotten the same error - would be good to get confirmed if that is because the token is bad or that something related to OIDC is done before the token is validated)
from codecov-action.
@jsoref will take it with you on this issue
from codecov-action.
@ssbarnea Your job is missing the id-token: write
permission.
Yes, the codecov.io side has to support this. It was broken but apparently they fixed it and uploading with OIDC works for a few days for me now.
from codecov-action.
@nfx can you provide some more details? Specifically the rest of the logs?
from codecov-action.
@G-Rath you're missing the permission -- I've added it in check-spelling-sandbox/eslint-plugin-jest@1ccd95e
But even with that it isn't working:
https://github.com/check-spelling-sandbox/eslint-plugin-jest/actions/runs/8944401881/job/24571265618#step:6:32
from codecov-action.
@jsoref we're not trying to use OIDC though so the permission should not be needed
from codecov-action.
@G-Rath ok, we made a change here, would you be able to see if you run into that log again?
from codecov-action.
@thomasrockhu-codecov, so, I'm forcing OIDC (https://github.com/check-spelling-sandbox/eslint-plugin-jest/blob/0e44095625c00fc931da2120f756788342f4b4f6/.github/workflows/nodejs.yml#L64, https://github.com/check-spelling-sandbox/eslint-plugin-jest/blob/0e44095625c00fc931da2120f756788342f4b4f6/.github/workflows/nodejs.yml#L113) and I've added enough logging (d09da3a) to show that OIDC is being used, but it still fails: https://github.com/check-spelling-sandbox/eslint-plugin-jest/actions/runs/8986717338/job/24683540548
==> Got an OIDC token
==> Got an OIDC token
==> Got an OIDC token
...
==> Uploader SHASUM verified (e70beb7c9e3d894678e7d4d0fcb94e59133212dbda5ca7406b625a0167ce4ca8 codecov)
info - 2024-05-07 14:00:41,045 -- ci service found: github-actions
debug - 2024-05-07 14:00:41,048 -- versioning system found: <class 'codecov_cli.helpers.versioning_systems.GitVersioningSystem'>
debug - 2024-05-07 14:00:41,0[51](https://github.com/check-spelling-sandbox/eslint-plugin-jest/actions/runs/8986717338/job/24683540548#step:6:52) -- versioning system found: <class 'codecov_cli.helpers.versioning_systems.GitVersioningSystem'>
debug - 2024-05-07 14:00:41,054 -- Loading config from /home/runner/work/eslint-plugin-jest/eslint-plugin-jest/.codecov.yml
debug - 2024-05-07 14:00:41,055 -- Starting create commit process --- {"commit_sha": "a07975eaa2b0aeb8af59[53](https://github.com/check-spelling-sandbox/eslint-plugin-jest/actions/runs/8986717338/job/24683540548#step:6:54)8d8f62e91c35d72739", "parent_sha": null, "pr": null, "branch": "my-repo-is-not-a-fork", "slug": "check-spelling-sandbox/eslint-plugin-jest", "token": "e******************", "service": "github", "enterprise_url": null}
info - 2024-05-07 14:00:41,270 -- Process Commit creating complete
debug - 2024-05-07 14:00:41,271 -- Commit creating result --- {"result": "RequestResult(error=RequestError(code='HTTP Error 400', params={}, description='[\"Repository not found\"]'), warnings=[], status_code=400, text='[\"Repository not found\"]')"}
error - 2024-05-07 14:00:41,271 -- Commit creating failed: ["Repository not found"]
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/check-spelling-sandbox/codecov-action/my-repo-is-not-a-fork/dist/codecov' failed with exit code 1
from codecov-action.
@nfx just wanted to circle back and see if a fix we made is working for you now
from codecov-action.
@thomasrockhu-codecov will check approx in 1.5 weeks
from codecov-action.
@thomasrockhu-codecov Works for me now
from codecov-action.
I find it bit perplexing as OIDC is advertised by this action but seems to to be supported by codecov.io itself.
Codecov: Failed to get OIDC token with url: https://codecov.io./ Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable
Basically, the default upload endpoint seems to not support it?
A search on https://sourcegraph.com/search?q=context:global+lang:yaml+%22use_oidc:+true%22&patternType=keyword&case=yes&sm=0 makes me believe that probably we don't have more than 10 repositories using it.
from codecov-action.
Thanks @jkreileder that does seem to be the issue @ssbarnea
@nfx going to close for now, please feel free to reopen if it's not working for you.
from codecov-action.
Related Issues (20)
- What does "full functionality" mean? HOT 1
- v4 keeps reporting HTTP Error 504 upstream request timeout very often HOT 1
- main Workflow is cruel to forks
- How can I turn off plugins? HOT 4
- I ended up using
- v4 cannot upload luacov report HOT 2
- osv-scanner: general issues HOT 3
- The following uploads failed to process HOT 1
- codecov.exe missing on Windows (randomly) HOT 4
- IsADirectoryError with v4.3.1
- Codecov action fails HOT 11
- Container builds are actually failing
- Can v4 still securely work with pull requests? HOT 12
- v4 fails if a broken symlink is present in the repo HOT 1
- scorecard analysis fails on forks with a different default branch
- codecov tries to fetch oidc token also on PR from fork
- Add support for send-notifications in codecov-action
- Codecov token not found on v4.4.1 HOT 5
- Upload fails on a `macos-14` runner HOT 1
- Upload fails on a `macos-12` runner HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codecov-action.