Git Product home page Git Product logo

Comments (8)

ibrahim0814 avatar ibrahim0814 commented on September 21, 2024 1

@nklayman I added that line to our readme on this commit

Thanks for the suggestion!

from codecov-action.

ibrahim0814 avatar ibrahim0814 commented on September 21, 2024 1

Hi all,

As of release v1.0.4, we've officially switched to using JavaScript for our action. It is now supported on Linux, macOS, and Windows. Feel free to use it your macOS and matrix builds :D

@adam7 Thank you for your initial suggestion!

Ib

from codecov-action.

adam7 avatar adam7 commented on September 21, 2024

Also fails on Windows with the same error.

from codecov-action.

adam7 avatar adam7 commented on September 21, 2024

Build failure is because this is a Docker Action which are only supported on Linux. Porting to a JavaScript Action would resolve the issue because they are supported on Windows, macOS and Linux.

https://help.github.com/en/articles/about-actions#types-of-actions

from codecov-action.

ibrahim0814 avatar ibrahim0814 commented on September 21, 2024

Hi all,

Copying my answer from #7 here:

Thank you for bringing this up. I've updated our README to reflect this particular caveat. GitHub currently allows us to build two types of Actions - Docker and JS. We decided to use a Docker action since it allows us to wrap our bash uploader because our bash uploader is the only uploader the Codecov staff actively maintains. Of course, this comes at the cost of sacrificing Windows and macOS build capabilities.

Perhaps in the future, we will support these other operating systems, but for the time being, I do apologize that this action's functionality is limited to only Linux

Ib

from codecov-action.

adam7 avatar adam7 commented on September 21, 2024

Looking at your entrypoint https://github.com/codecov/codecov-action/blob/master/entrypoint.sh all your container does is download and then run a binary which you could just as easily do in a JavaScript Action and would give you cross platform support.

from codecov-action.

ibrahim0814 avatar ibrahim0814 commented on September 21, 2024

@adam7 I'll look this, I wasn't aware that it was possible but perhaps my assumptions are incorrect here.

from codecov-action.

nklayman avatar nklayman commented on September 21, 2024

Maybe you should add if: runner.os == 'Linux' to the readme example for now.

from codecov-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.