Comments (7)
@kdarkhan strange, that should be allowed. Let me try to dig in here and see what's the prlblem
from codecov-action.
@kdarkhan ok, actually I dug into this quite a bit more.
v4 should work if you specify
directory: ${{ github.workspace }}
You can see the it used here.
But why was this working on v3?
I'm not completely sure right now. I think there may have actually been a bug in our file searcher that wasn't taking into account the root directory properly.
from codecov-action.
I confirm that the latest v4 works for our subdirectory use case, so closing out this issue. The discussion above sounds like it's a separate issue from what I filed, so perhaps create a new one for it?
Thanks @thomasrockhu-codecov !
from codecov-action.
@bmulholland I made a few changes to v4
, would you be able to try the latest?
from codecov-action.
@thomasrockhu-codecov I tested the latest version in kdarkhan/mdbook-i18n-helpers#39
The action did not fail but it does not seem to be able to find the coverage file for some reason.
The action exec log is available here.
From the log, it states:
warning - 2024-02-26 23:35:04,232 -- Some files were not found --- {"not_found_files": ["/home/runner/work/mdbook-i18n-helpers/mdbook-i18n-helpers/codecov_report.json"]}
which is very strange since I did ls
just above (in Run pwd
step), and do see that the coverage report file is available. My setup is a bit different as my coverage report file is not located within the repo_root. Is that allowed? It used to work like that in v3.
from codecov-action.
@kdarkhan ok, I found the source in the CLI
I'll work on a fix for this.
from codecov-action.
Thanks for looking into this, I will try later today.
In v3 I was using root_dir
instead of working-directory
. It failed with that in v4 and hence the change. I did not notice that there is a separate directory
parameter now.
from codecov-action.
Related Issues (20)
- What does "full functionality" mean? HOT 1
- v4 keeps reporting HTTP Error 504 upstream request timeout very often HOT 1
- main Workflow is cruel to forks
- How can I turn off plugins? HOT 4
- I ended up using
- v4 cannot upload luacov report HOT 2
- osv-scanner: general issues HOT 3
- The following uploads failed to process HOT 1
- codecov.exe missing on Windows (randomly) HOT 4
- IsADirectoryError with v4.3.1
- Codecov action fails HOT 10
- Container builds are actually failing
- Can v4 still securely work with pull requests? HOT 12
- v4 fails if a broken symlink is present in the repo HOT 1
- scorecard analysis fails on forks with a different default branch
- codecov tries to fetch oidc token also on PR from fork
- Add support for send-notifications in codecov-action
- Codecov token not found on v4.4.1 HOT 5
- Upload fails on a `macos-14` runner HOT 1
- Upload fails on a `macos-12` runner HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codecov-action.