Git Product home page Git Product logo

Comments (13)

ldemailly avatar ldemailly commented on August 24, 2024 1

Thoughts?

from codecov-action.

rohan-at-sentry avatar rohan-at-sentry commented on August 24, 2024 1

@ldemailly taking a look

from codecov-action.

rohan-at-sentry avatar rohan-at-sentry commented on August 24, 2024 1

@ldemailly my apologies - This dropped of my radar!

@thomasrockhu @drazisil-codecov can you help out here?

from codecov-action.

thomasrockhu avatar thomasrockhu commented on August 24, 2024 1

@thomasrockhu-codecov

from codecov-action.

thomasrockhu-codecov avatar thomasrockhu-codecov commented on August 24, 2024 1

@ldemailly, apologies, I'm not quite understanding the issue right now. Is it that when you bump to v4 that you are getting an unusable report error?

We have since made some changes to the underlying CLI, would you be able to try it again?

from codecov-action.

ldemailly avatar ldemailly commented on August 24, 2024 1

I changed how I gather coverage, I used to do it package by package this way:

#!/usr/bin/env bash

set -e
echo "" > coverage.txt
rm -f profile.out

for d in $(go list ./... | grep -v vendor); do
    echo "### Working on package coverage $d"
    go test -coverprofile=profile.out -covermode=atomic $d
    if [ -f profile.out ]; then
        cat profile.out >> coverage.txt
        rm profile.out
    fi
done

and maybe that was creating the mix up above, or you fixed something because now it works with my simpler/more direct coverage

This being said... I'd rather not have to change a dozen repos to add

        token: ${{ secrets.CODECOV_TOKEN }}

why is that now (in v4) needed for public repos?

from codecov-action.

ldemailly avatar ldemailly commented on August 24, 2024

@thomasrockhu-codecov Retried worked (past that 502) but now back to "unusable report"

info - 2024-02-09 20:45:56,383 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/fortio/fortio/commit/88cbb9365d06f05d152266366aff6846ed9c98d9

https://api.codecov.io/upload/gh/fortio/fortio/download?path=v4/raw/2024-02-09/C0DD8D0DDF23CE2B21C69976960C6C9E/88cbb9365d06f05d152266366aff6846ed9c98d9/c98b1e47-8fe3-48f2-8434-f8de0d2b9115/1ff1743d-3047-49cc-8650-c28256fdab22.txt

from codecov-action.

ldemailly avatar ldemailly commented on August 24, 2024

ping? https://app.codecov.io/gh/fortio/fortio/commits dropped to 0% as a result

from codecov-action.

ldemailly avatar ldemailly commented on August 24, 2024

Another one despite using 4.0.2 of the action:

https://app.codecov.io/github/fortio/fortio/commit/a3a4496ae4f8dfc42ba9577d49f44537f00a30aa

seems the issue is a mix of plain text and compressed coverage in the report:

[...] , 386, 387, 394, 398, 399, 400, 401, 406, 407, 410, 411, 414, 415, 419, 420, 422, 423, 424, 425, 430, 436, 437, 438, 440, 444, 454, 455, 460, 462, 463, 464, 468, 471, 476, 479, 485, 488, 489, 494, 497]}, "version/version.go": {"eof": null, "lines": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 21, 23, 28, 29, 30, 31, 32, 33, 36, 37, 38, 39, 42, 43, 44, 45, 48, 49, 50, 51, 54]}}}, "network_files": [".circleci/config.yml", ".circleci/coverage.sh", ".github/dependabot.yml", ".github/workflows/codecov.yml", ".github/workflows/codeql-analysis.yml", ".github/workflows/main.yml", ".github/workflows/manual-build.yml", ".github/workflows/test.yml", ".gitignore", ".golangci.yml", ".testdata/payloadTest1.txt", "CONTRIBUTING.md", "Dockerfile", "Dockerfile.build", "Dockerfile.echosrv", "Dockerfile.fcurl", "LICENSE", "Makefile", "README.md", "SECURITY.md", "Webtest.sh", "bincommon/commonflags.go", "cert-gen", "cli/fortio_main.go", "cli_test.go", "cli_test.txtar", "codecov.yml", "debian/changelog", "debian/compat", "debian/control", "debian/copyright", "debian/rules", "debian/source/format", "debian/source/lintian-overrides", "dflag/README.md", "dflag/dflag.go", "docs/fortio-logo-color.png", "docs/fortio-logo.gvdesign", "docs/fortio-logo.svg", "docs/fortio.1", "echosrv/echo.go", "fcurl/fcurl.go", "fgrpc/grpcrunner.go", "fgrpc/grpcrunner_test.go", "fgrpc/ping.pb.go", "fgrpc/ping.proto", "fgrpc/pingsrv.go", "fgrpc/pingsrv_test.go", "fhttp/http_client.go", "fhttp/http_forwarder.go", "fhttp/http_forwarder_test.go", "fhttp/http_loglevel_test.go", "fhttp/http_server.go", "fhttp/http_test.go", "fhttp/http_utils.go", "fhttp/httprunner.go", "fhttp/httprunner_test.go", "fhttp/https_server_test.go", "fnet/network.go", "fnet/network_norace_test.go", "fnet/network_stdin_test.go", "fnet/network_test.go", "go.mod", "go.sum", "histogram/main.go", "jrpc/jrpcClient.go", "jrpc/jrpcServer.go", "jrpc/jrpc_test.go", "log/logger.go", "main.go", "metrics/Makefile", "metrics/metrics.go", "metrics/prometheus.yml", "periodic/periodic.go", "periodic/periodic_loglevel_test.go", "periodic/periodic_test.go", "rapi/data.go", "rapi/restHandler.go", "rapi/restHandler_test.go", "release/.gitignore", "release/Dockerfile.in", "release/Makefile.dist", "release/README.md", "release/bumpRelease.sh", "release/ffpm.sh", "release/release.sh", "release/updateFlags.sh", "stats/stats.go", "stats/stats_test.go", "tcprunner/tcprunner.go", "tcprunner/tcprunner_test.go", "udprunner/udprunner.go", "udprunner/udprunner_test.go", "ui/static/css/fortio.css", "ui/static/img/favicon.ico", "ui/static/img/fortio-logo-gradient-no-bg.svg", "ui/static/img/fortio-logo-white-bg.svg", "ui/static/img/fortio-logo-white-on-gradient.svg", "ui/static/img/fortio-logo.svg", "ui/static/img/logo.svg", "ui/static/js/Chart.min.js", "ui/static/js/fortio_chart.js", "ui/templates/browse.html", "ui/templates/header.html", "ui/templates/main.html", "ui/templates/sync.html", "ui/uihandler.go", "version/version.go"], "coverage_files": [{"filename": "/home/runner/work/fortio/fortio/coverage.txt", "format": "base64+compressed", "data": "eJylnc22LDeOnef1FPcBYmUF/8maeuK5H8BLltRl2VWS1i1V9+sbe4N5TpxMMhOQBx1H1Su+i0gGgz8gsPGXf/72089/+/bDH7/985cf//Ifv33/45ffbr99//tf9T//+s8ffvn19vff/hbjLaQj5lv8Fr6dr25st9COdMqN8Vv+y5d//v/7fzyb/Y+/f//9x7/i8v3fv/7683c8Qo63Mo6cby3LM4QzWzkQR67yA4Qr1YoBOHK/ZWmaaIXGLR3lvHU8YrE+YQm3fpR0S2IpdyskL+0o5ZZOtob1CUkcpd1G55s0Urj/KIONYYVqkCes6Rbqt+R4QhJHLWyOVZ9cQhW25JV1gey2er+FMxxD2j5/K99CjtYfR+QY+pTd+pgDj4nLicd0WANyjE5r4TzN9rr0LPmFt1DkHdjtKSJkvqEnp2o1GE78wnA2vPXo+YnKHCEE+ZHpWzVzIcJiSLeCHh0cz0pGUH2JLpK/ [...]

from codecov-action.

ldemailly avatar ldemailly commented on August 24, 2024

same with 4.1.0 https://app.codecov.io/github/fortio/fortio/commit/360913cefff2af7482c1dba8e7a545ee08aba8d4

from codecov-action.

ldemailly avatar ldemailly commented on August 24, 2024

ps: wanted to downgrade to v3 meanwhile but getting

[2024-03-06T12:12:34.707Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Could not find a repository associated with upload token ***', code='not_found')}

my CODECOV_TOKEN works with v4 (well however much v4 works)

from codecov-action.

ldemailly avatar ldemailly commented on August 24, 2024

removing the token (!) v3 finally passed and the format is quite different

https://storage.googleapis.com/codecov/v4/raw/2024-03-06/C0DD8D0DDF23CE2B21C69976960C6C9E/a6470bfeeca554f3c0a1bc170e2b983e745ae5a0/fae2be97-0801-4022-8304-745edfe2e296.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=GOOG1EJOGFN2JQ4OCTGA2MU5AEIT7OT5Z7HTFOAN2SPG4NWSN2UJYOY5U6LZQ%2F20240306%2FUS%2Fs3%2Faws4_request&X-Amz-Date=20240306T123514Z&X-Amz-Expires=30&X-Amz-SignedHeaders=host&X-Amz-Signature=a4ae6280754605346bb714aa29535b398d27d38dde88b2e4d9257029f6d2a277

I hope v3 will stay working very long and v4 is fixed as well (including token weirdness) - thanks @rohan-at-sentry

from codecov-action.

ldemailly avatar ldemailly commented on August 24, 2024

@rohan-at-sentry I hope everything is ok with you - any update?

from codecov-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.