VS2012 can hang on build with auto-cleanup and unsaved changes about codemaid HOT 4 CLOSED

I spent some time debugging, and here are some notes for when I can next pick it back up.

Code model generation triggered from RDT.BeforeSave to construct a model for cleaning works fine and runs on the UI thread.

Code model generation triggered from RDT.AfterSave to construct an updated model for digging sometimes fails and runs on the background thread.

The AfterSave scenario will always re-generate the code model currently due to SpadeToolWindow.ConditionallyUpdateCodeModel's call to _codeModelManager.OnDocumentChanged(Document) within a refresh scenario. Taking out this line of code is a good optimization as the logic to catch a stale document from LineChanged seems robust enough that this force refresh shouldn't(tm) be necessary.

Bypassing the re-generation avoids the error, but if cleaning caused any code model changes then re-generation would be required and the hang will still be exhibited.
Experimented with just making CodeModelBuilder.RetrieveCodeRegions run on the UI thread, but the same hang was exhibited.

A performance option to disable asynchronous code model loading might be a good idea at this point. Alternatively, it may be worthwhile to explore if the code model can be generated synchronously when called from a refresh context.

from codemaid.

Checked in a performance option for loading models asynchronously (on by default). This can be disabled which should force the UI thread to be used for building the model and work around this issue.

from codemaid.

Hi codecadwallader,
Thx for your amazing extension, I can't work without Spade since I installed it 6 years ago !
Took me a while but I discovered that I really have to uncheck "Load models asynchronously" because it took about 6-8 seconds to finish refreshing/loading when saving. It was just too annoying because I save my work very often. So unchecked this option was the solution.

from codemaid.

@FlouFlou Cool, I'm glad to hear that you've been enjoying it. :) Also thanks for sharing that flipping that setting was helpful for you as it may be helpful for others.

from codemaid.