Comments (5)
Hmm, I can't seem to reproduce this. The highlight box is tied to the page coordinates of the selected element, so it should just stay in the same place when you scroll.
Do you have a scrolling container? That might cause this since then the page coordinates of the selected element might change. What happens when you move the tour component into the scrolling container?
from telemachy.
I was able to reproduce this in Chrome on OS X.
- Start a tour
- View some steps, highlight some elements
- Scroll
- During scrolling, the element stays highlighted correctly
- Go next
- The next element is highlighted where it was when the tour began, not where it is now.
from telemachy.
Hi,
You're right, I have a scroll container, and it's the same result when I move the tour component inside.
When you calculate the coordinates of the overlay, you use 'document.body.scrollTop', I try with 'window.pageYOffset' (due toIE) instead and this solves the problem.
Do you think you can fix it or do you prefer that I submit a PR?
from telemachy.
If you could submit a PR, that'd be great! If not, I think I can get around to this somewhere next week as I've run into this with another project myself.
from telemachy.
I submited a PR
from telemachy.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from telemachy.