Ensure that it returns the same result no matter how many times it's called. <p di

Call `(p periodical[T]) Slice()` some times, the results will be different each time about synchro HOT 1 CLOSED

Code-Hex commented on June 10, 2024

Call `(p periodical[T]) Slice()` some times, the results will be different each time

from synchro.

Comments (1)

Code-Hex commented on June 10, 2024

I thought about modifying the logic like this, but since I can't think of a use case I want to use it for, I'll leave it as is for now.

index 79aed80..e602892 100644
--- a/period.go
+++ b/period.go
@@ -2,6 +2,8 @@ package synchro

 import (
        "fmt"
+       "runtime"
+       "sync"
        "time"
        "unsafe"

@@ -69,11 +71,16 @@ func (p Period[T]) Contains(t Time[T]) int {

 type periodical[T TimeZone] <-chan Time[T]

+var pCache sync.Map
+
 // Slice returns the slice of Time[T].
 func (p periodical[T]) Slice() (s []Time[T]) {
        for current := range p {
                s = append(s, current)
        }
+       if cache, ok := pCache.LoadOrStore(p, s); ok {
+               return cache.([]Time[T])
+       }
        return s
 }

@@ -99,9 +106,15 @@ func (p Period[T]) Periodic(next func(Time[T]) Time[T]) periodical[T] {
                        ch <- current
                }
        }()
+       runtime.SetFinalizer(&ch, func(ch *chan Time[T]) {
+               pCache.Delete(*ch)
+       })
        return ch
 }

 func isNotAfter[T TimeZone](t1, t2 Time[T]) bool {
        // t1.Compare(t2) <= 0
        return !t1.After(t2)
diff --git a/period_test.go b/period_test.go
index dbb0bd8..35bc27f 100644
--- a/period_test.go
+++ b/period_test.go
@@ -2,6 +2,7 @@ package synchro