Switch ember-cli-page-object to native DOM helpers about code-corps-ember HOT 3 OPEN

Hello!

I made an attempt at this and ran into issues about whether this is possible.

I made the changes as outlined here:

http://ember-cli-page-object.js.org/docs/v1.13.x/native-events

This broke 12 tests total, all which seem to be tool tip related. I spent some time doing some digging. And this caught my eye in the native-events docs for ember-cli-page-object:

If you want to use native-events mode in your test suite, you have to ensure that your app is ready to handle native DOM events rather than jQuery events.

I don't know if this extends to addons, if so it looks like ember-tooltip uses jquery events which might disqualify its usage.

I used
Integration | Component | conversations/conversation part comment: it renders all the details

which failed on step:

assertTooltipNotRendered(): the ember-tooltip should not be rendered

getTooltipFromBody(): returned an element that is not a tooltip

Which is from the ember-tooltips test support
https://github.com/sir-dunxalot/ember-tooltips/blob/master/test-support/helpers/ember-tooltips.js

Thoughts?

from code-corps-ember.

@jderr-mx Sorry for the delayed response.

It looks like you did some work on it either way, so it would certainly be good for creating a PR. At that point, we can figure out if we can get past the tooltip issue.

It may, for example, be possible to write our own tooltip helpers instead of dealing with the ones provided with the addon. That might be enough to get the tests passing.

from code-corps-ember.

@begedin This is good timing, I am at EmberConf so it is a good time for me to revisit it. I'll start with a PR.

from code-corps-ember.