Git Product home page Git Product logo

Comments (7)

rzfzr avatar rzfzr commented on August 17, 2024 3

Great job,
hope the PR will be approved soon,
for now I have been using a combination of extensions that have served me well, however it would still be nice to have it all in one place.

This is for the shortcuts, works in any html5 video: https://chrome.google.com/webstore/detail/video-speed-controller/nffaoalbilbmmfgbnbgppjihopabppdk

This is for correcting the timeline and showing some stats (nice to haves in InprovedTube aswell): https://chrome.google.com/webstore/detail/youtube-time-tools/cobnfdhokdhiglbojmoapeccpbhonhgi

Take a look at these stats:
image

from youtube.

Venryx avatar Venryx commented on August 17, 2024 2

Turns out that it was indeed pretty straight-forward (though a bit more lines than expected since the extension has three places in code that can modify the playback speed!).

The pull-request (seen above) will now let users set the playback rate to anything between 0.1x and 16x. (the maximum range allowed for html5 videos)

this one even allows you to assign shortcut key.

By the way, assigning a shortcut key is already possible apparently through the "Popup->Shortcuts->[Increase/Decrease] Playback Speed" control. Tested and confirmed working with my PR above.

from youtube.

Venryx avatar Venryx commented on August 17, 2024 1

Can this issue please be re-opened?

My PR (#161) fixed this issue, however unfortunately the commit added to the end of the pull-request reverted some of my changes which were necessary to enable >2x playback speed for shortcut-key-based playback-speed changing.

Specifically, some of the changes in this linked commit and file (shortcuts.js -- it takes a while for the page to load and scroll), need to be re-added to get the >2x playback speed working for shortcut-keys: 7bed14e#diff-601eca5729d827909938694dc3c90d47

@victor-savinov Is there a reason you reverted the changes linked above? If so, how can it be changed to be acceptable? If the varying speed-adjustment increment is disliked, we can remove that part and just keep the fix enabling >2x playback-speed.

(I tried out the latest version of the extension, and confirmed that it maxes out at 2x, because the changes linked to above have the code regress to using player.setPlaybackRate, instead of videoNode.playbackRate, which is required to bypass the 2x speed.)

from youtube.

fazlerabbi37 avatar fazlerabbi37 commented on August 17, 2024

this one even allows you to assign shortcut key.

from youtube.

rzfzr avatar rzfzr commented on August 17, 2024

this one even allows you to assign shortcut key.

yep, but it has permission to read your history and is not open source from what I could see, so that's a no go

from youtube.

Venryx avatar Venryx commented on August 17, 2024

Some extensions do it, might be one line of JS

Indeed, it should be quite simple to implement. I know because it's literally only one line of code, even just running in the regular dev-tools console.

Just press F12 to open the dev-tools panel, switch to the Console tab, and run:

document.querySelector("video").playbackRate = 16; // or some other value

Since it's so straight-forward, it seems worth the few minutes to add.

(I tried modifying the template-parts/player.js file to allow a greater-than-2 max-value for the setting, and while that lets the user set it higher, apparently the method the plugin uses to apply it fails for values past 2. That's why the application method would have to be changed to the direct method described above.)

from youtube.

wadawada avatar wadawada commented on August 17, 2024

I'm using this one. I like to drag
https://chrome.google.com/webstore/detail/speed-control/licimfihnglekdccgjijhmfdocplhdbk

from youtube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.