Git Product home page Git Product logo

Comments (2)

aaronc avatar aaronc commented on September 23, 2024

So looking at the Quo code, there are a lot of for loops. It looks like it's trying to do things digit by digit. Is this algorithm designed around cases with very large precision? What if there were a fast path for precision <= 34 (decimal128, etc.)?

I benchmarked some decimal128 code based on https://software.intel.com/content/www/us/en/develop/articles/intel-decimal-floating-point-math-library.html by the way and division is comparable to multiplication there. So it must be possible for apd to have a more efficient Quo implementation for "low" precision.

from apd.

nvanbenschoten avatar nvanbenschoten commented on September 23, 2024

Hi @aaronc, thanks for the report. Quo performance has improved recently (it's about 50% faster on your benchmark), but it still lags the performance of other operations by quite a margin. As you identified, this has to do with the digit-by-digit loop in Quo. The algorithm is designed around cases with very large precision and does not include any form of fast-path for low precision values. I'd like to keep this issue open to track the introduction of such a fast path.

from apd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.