Git Product home page Git Product logo

Comments (3)

seb86 avatar seb86 commented on May 22, 2024

@njbotkin How would do you see the notices returned? Don't forget this API has to support different languages that could be used to build a custom app.

from co-cart.

njbotkin avatar njbotkin commented on May 22, 2024

Don't you think i18n would be handled by Woocommerce? The code that I'm using to implement a (fairly specialized) API for a client has departed pretty radically from WC style standards, so I doubt you want a PR 😛. But here's how I'm diffing notices, if you want any ideas:

// takes a diff of WC notices before and after operation
function notice_sandwich($f) {
	$old = WC()->session->get( 'wc_notices', array() );
	$f();
	$new = WC()->session->get( 'wc_notices', array() );

	// remove new notices from notice queue
	wc_set_notices($old);

	return woocommerce_notices_diff($old, $new);
}

function woocommerce_notices_diff($old, $new) {
	$diff = [];
	if(isset($old['error'])) {
		$diff['error'] = array_slice($new['error'], count($old['error']));
	} elseif(isset($new['error'])) {
		$diff['error'] = $new['error'];
	}
	if(isset($old['success'])) {
		$diff['success'] = array_slice($new['success'], count($old['success']));
	} elseif(isset($new['success'])) {
		$diff['success'] = $new['success'];
	}
	return $diff;
}

Usage:

$coupon_code = wc_clean( $data['coupon_code'] );

$notices = notice_sandwich(function() use($coupon_code) { 
	WC()->cart->apply_coupon($coupon_code);
}); 

As far as how error and message responses are structured, I'm not sure how you'd move forward without introducing breaking changes.

from co-cart.

seb86 avatar seb86 commented on May 22, 2024

@njbotkin Thank you for sharing but I don't think that is the approach we are looking for.

from co-cart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.