Git Product home page Git Product logo

Comments (3)

taylor avatar taylor commented on July 29, 2024

@wavell @denverwilliams @williscool please add A/C before moving to Needs Peer Review

from testsuite.

lixuna avatar lixuna commented on July 29, 2024

Acceptance Criteria:

Common steps

  • Find or create a K8s cluster to use
    • Steps for creating will be in another ticket
    • Talk with team for access to an existing cluster
  • Set the KUBECONFIG environment variable for accessing the target K8s cluster
  • As a developer, Pull down latest version of CNF conformance test code from develop branch
  • As a peer reviewer, Pull down latest version of CNF conformance test code from master branch
  • Run shards install
  • Run crystal spec
  • I expect to see PASSED for the tests

When using the test crystal src/cnf-conformance.cr liveness command the sample "good" CNF should PASS test successfully:

  • Run crystal src/cnf-conformance.cr setup
  • Run crystal src/cnf-conformance.cr sample_coredns_setup
  • Run crystal src/cnf-conformance.cr liveness
  • I expect to see the output and results from the test
  • I expect to see PASSED for the test

When using the test crystal spec --tag 'liveness' command the sample "good" CNF should PASS and the sample "bad" CNF should FAIL test:

  • Run crystal spec --tag 'liveness'
  • I expect to see the output and results from the test
  • I expect to see "PASSED: Helm liveness probe found"
  • I expect to see "FAILURE: No livenessProbe found"

I would expect the CNF to pass when I run the entire test category suite (configuration_lifecycle)

  • Run crystal src/cnf-conformance.cr configuration_lifecycle
  • I expect to see the output and results from all tests in the test category
  • I expect to see PASSED for the test category

I would expect the CNF to pass when I run the entire test suite (all)

  • Follow common steps above
  • Run crystal src/cnf-conformance.cr all
  • I expect to see the output from the test
  • I expect to see PASSED for the test

Steps after A/C fails

If all A/C fails for peer reviewer

  • Add a comment to the PR summarizing the problem tagging the developer
  • Attach any console output or logs that can help the developer fix the issue

Steps after A/C Passes

If all A/C passes for developer

  • open a Pull Request to master branch and mark as "developer approved"
  • Tag team members for peer review

If all A/C passes for peer reviewer

  • Mark the PR as approved and merge the PR into master

from testsuite.

lixuna avatar lixuna commented on July 29, 2024

Level of effort in pts: 0, 1, 2, 3, 5, 8, 13, 21 = 5 pts

@wavell 5 pts
@denverwilliams 5 pts
@taylor 3 pts
@lixuna 5 pts

from testsuite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.