Git Product home page Git Product logo

Comments (8)

cmsbuild avatar cmsbuild commented on August 22, 2024

A new Issue was created by @kpedro88 Kevin Pedro.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

from cms-bot.

smuzaffar avatar smuzaffar commented on August 22, 2024

Thanks @kpedro88 for opening the issue. This is on our to do list. @mrodozov is looking in to it. We are thinking of a special comment e.g.

test parameters/settings
pull_requests=#PR1,#PR2,cms-sw/cmsdist#PRn
workflows=534.0,540.0
release=CMSSW_11_0_DEVEL_X
architecture=slc7_amd64_gcc900
full_build=true|false

bot then can use the settings from the last such comment made by a user, who has rights to start tests. One can still override part of settinsg via please test .... comment

Is this sound reasonable?

from cms-bot.

fabiocos avatar fabiocos commented on August 22, 2024

@smuzaffar is the syntax of these extra settings flexible or rigid? I mean are all the fields always needed, or the default will be used unless specified otherwise? I guess the latter is what we want.
What about possible changes of settings during the PR review? They will be always possible I guess...

from cms-bot.

kpedro88 avatar kpedro88 commented on August 22, 2024

@smuzaffar this looks reasonable to me, thanks

Maybe worthwhile to have separate items for CMSSW PRs vs external PRs?

It would also be nice to have an option for the bot to print all the specified test settings, in case they get updated piecemeal over the course of a long PR review.

from cms-bot.

mrodozov avatar mrodozov commented on August 22, 2024

@kpedro88 pls see #1234 and maybe close this.

from cms-bot.

kpedro88 avatar kpedro88 commented on August 22, 2024

@mrodozov can you provide some description of how the new functionality works (preferably in the cms-bot command documentation so it's clear to everyone)?

from cms-bot.

smuzaffar avatar smuzaffar commented on August 22, 2024

@kpedro88 , there are still few issues with this thatis why I did not advertise or updates here. Basic documentation is available cms-bot commands page http://cms-sw.github.io/cms-bot-cmssw-cmds.html but we are still testing this feature.

from cms-bot.

kpedro88 avatar kpedro88 commented on August 22, 2024

Okay, since this is nominally in place, the issue can be closed. Thanks!

from cms-bot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.