Git Product home page Git Product logo

Comments (9)

cmsbuild avatar cmsbuild commented on August 22, 2024

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

from cms-bot.

kpedro88 avatar kpedro88 commented on August 22, 2024

Maybe we could make a version of it that only prints the summary? The per-event info makes the logs huge and hard to read, and I usually don't find it very useful.

from cms-bot.

kpedro88 avatar kpedro88 commented on August 22, 2024

Ah, that is the summary version, distinct from TimeMemoryInfo.

from cms-bot.

fabiocos avatar fabiocos commented on August 22, 2024

We are not printing Time info per event, just memory jumps when they happen....
Still the trigger output summary is huge when written (and timing detail as well)

from cms-bot.

fabiocos avatar fabiocos commented on August 22, 2024

@smuzaffar in case, looking at the bot code, in particular https://github.com/cms-sw/cms-bot/blob/master/run-pr-tests#L640 this update would men adding to EXTRA_MATRIX_ARGS --command "--customise Validation/Performance/TimeMemorySummary.py" right?

from cms-bot.

smuzaffar avatar smuzaffar commented on August 22, 2024

@fabiocos , yes that is the correct place. As it is available in all release cycles so we can just hard code it here https://github.com/cms-sw/cms-bot/blob/master/run-pr-tests#L640

from cms-bot.

fabiocos avatar fabiocos commented on August 22, 2024

@smuzaffar should we consider also https://github.com/cms-sw/cms-bot/blob/master/pr_testing/test_multiple_prs.sh#L836 ?

from cms-bot.

smuzaffar avatar smuzaffar commented on August 22, 2024

yes that should be updated but I will ask @gudrutis to sync in other changes too. For now #1112 is good enough to go in.

from cms-bot.

smuzaffar avatar smuzaffar commented on August 22, 2024

I have merged #1112 and @gudrutis is going to fix the test_multiple_prs to include the changes.

from cms-bot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.