Comments (4)
Read #1 again, realized that patch only fixed the error throw, not the empty body.
from superdeno.
@asos-craigmorten Thanks for the investigation. That's right, I didn't realise I was using the HEAD request. I was definitely too blind to find that.
from superdeno.
Hi @ngot I've added a test for this for both Oak and Ako in 1.6.0
.
I believe the issue is that in the sample test you are making a HEAD
request which will discard the body, whereas in your curl
request you are implicitly using a GET
request, so the body is returned.
Test added here: https://github.com/asos-craigmorten/superdeno/blob/main/test/supertest.ako.test.ts#L7 and passing in CICD.
from superdeno.
No worries - thanks for raising anyway! Lead to some extra tests and a small refactor so all good 🎉
from superdeno.
Related Issues (20)
- Submitting a payload with a get request results in request termination error HOT 5
- [BUG] Error thrown on empty body responses (e.g. 304)
- Consider using Pagic to build the website? HOT 1
- [BUG] res.header vs res.headers typescript issues
- [CHORE] Use Deno's inspect instead of one from NPM HOT 2
- SuperDeno does not process headers in the response from Opine HOT 4
- Re-introduce multiple cookie headers in test HOT 1
- Question: testing if header doesn't exist HOT 2
- Expected "Hello World" response body, got "HTTP/1.1 20" HOT 10
- Support new [email protected]/http API HOT 3
- Error: Request has been terminated for native http server HOT 4
- Couldn't make `multipart/form-data` requests with oak. HOT 4
- Getting async leaking error when testing opine v2 HOT 3
- Attach is possibly not sending the actual file to the app HOT 1
- `HandlerLike` signature doesn't match actual `server.Handler`. Missing `connInfo` HOT 5
- Question: How to run superdeno with plain deno server HOT 2
- Can this be used with `express`? HOT 1
- How does superdeno intercept redirects? HOT 8
- Release 1.5 causing an error on download HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from superdeno.