Calling req.body.read() in a post or put method crashes deno about opine HOT 2 CLOSED

Curious! The error is coming from the std/http lib module which Opine uses, but worth checking that not doing something strange with the body in Opine…

Be curious to know if is reproduceable with just the std/http lib (outside of Opine).

from opine.

@creeperkafasi sorry took so long to look into this a bit more.

In this instance it is a case of the std lib's buffer read implementation not giving you back a particularly good error message 😅 the read(p: Uint8Array) requires you to pass a Uint8Array to which the stream can be read into. For example, we can fix up your example as follows:

import { opine, serveStatic } from "./mod.ts";

const port = 3000;
const hostname = "127.0.0.1";

const app = opine();

app
  .use("/public", serveStatic(`${Deno.cwd()}/public`))
  .post("/msg", async (req, res, _next) => {
    // Determine the size of the message and therefore how big a buffer we need.
    const contentLength = parseInt(req.headers.get("content-length") ?? "0");
    const buffer = new Uint8Array(contentLength);

    // Read the request body into our buffer
    await req.body.read(buffer);

    // Do something with that buffer - here we just respond with it to the POST request.
    res.send(buffer);
  });

app.listen({ port, hostname }, () => {
  console.log(`http://${hostname}:${port}`);
});

If you want to look into the method a bit more, check out [he potential return types of the request body provided by the legacy http std lib module (REF: https://deno.land/[email protected]/http/server_legacy.ts#L91), and the core Deno docs on the Deno.Reader interface which the http body satisifies (REF: https://doc.deno.land/builtin/stable#Deno.Reader).

I would also check out the Opine docs on req.body (REF: https://github.com/asos-craigmorten/opine/blob/main/.github/API/request.md#reqbody) including some of the body parsing middleware that Opine provides, namely:

• json()
• raw()
• text()
• urlencoded()

These can likely save you some time writing bespoke code for parsing and consuming the request body 😄

As this is an error with using the read() method rather than a bug with Opine, I'm going to close - please reopen if disagree!

from opine.