Comments (3)
cludden
commented on June 8, 2024
1
These are great suggestions, and timely, as after some heavy internal usage, we've started to investigate other potential breaking changes here (which covers your proposal 2 and 3, by specifically making options args an optional/variadic. We'll definitely consider converting these options to "configurator functions" to better support future extension
edit: I've opened a larger issue to track these and other suggestions here, would appreciate it if you'd be willing to share your thoughts
from protoc-gen-go-temporal.
ZloyDyadka
commented on June 8, 2024
@cludden Oh, I didn't know about the v1 branch :(
I've already started working on Activities Sync\Async, but I took from main, so I'll transfer the changes from v1 and integrate them into my branch.
Once I'm done, I'll create an MR with Activities, and if that's okay, then I'll do something similar for Workflow\Signals.
ZloyDyadka/protoc-gen-go-temporal@main...ZloyDyadka:protoc-gen-go-temporal:sync-asyc-activities
from protoc-gen-go-temporal.
cludden
commented on June 8, 2024
I've moved these proposals to the checklist for v1 and will track their status there. Thanks again for the suggestions!
from protoc-gen-go-temporal.
Related Issues (20)
- move default options to top-level method options
- restrict rpc method combinations
- support default search attributes
- support cli generation
- support TestClient compatible with testsuite
- support doc generation
- refactor method options as functional to support future extension
- support multiple proto services in a single package
- support multiple flavors of activity executors to avoid having to pass nil function
- Buf remote plugin HOT 3
- UpdateOptions.Validate clashes with Validate() method generated by protoc-gen-validate HOT 2
- Override default task queue for activity doesn't work HOT 1
- Generating standalone activities without workflows HOT 4
- question/improve: add helper functions for changing options HOT 7
- v1 roadmap HOT 1
- Add WithDataConverter helper to relevant options
- Wrap expression evaluation in local activity in workflow contexts
- support workflow update
- make StartWorkflowOptions, ActivityOptions, LocalActivityOptions, ChildWorkflowOptions optional
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protoc-gen-go-temporal.