Comments (5)
Hey @rlerdorf. Thanks for flagging this. I have raised this with the development team to be addressed in a future release of the SDK.
Thanks,
-Danny Valentine @ Cloudinary Support
from cloudinary_php.
Hi @rlerdorf.
I'm afraid as this is for the legacy PHP SDK, we are no longer offering support. Instead, we'd advise you to please upgrade to the V2 SDK if possible.
Many thanks,
-Danny
from cloudinary_php.
I totally understand that you no longer want to make updates to v1 of your SDK, but our team does not have bandwidth to upgrade that currently and your SDK is the only composer package we are using that is causing issues with PHP 8.2
Given how straightforward the fix is, is there any way to get that in?
Otherwise we'll look into forking your repo, upgrading, or replacing Cloudinary.
Note that I believe that there is a miss on the first $min_width instance in @rlerdorf's diff. Here is what we've been using when testing locally:
diff cloudinary/cloudinary_php/src/Helpers.php.old cloudinary/cloudinary_php/src/Helpers.php
256c256
< $width_param = "auto:breakpoints_${min_width}_${max_width}_${kbytes_step}_${max_images}:json";
---
> $width_param = "auto:breakpoints_{$min_width}_{$max_width}_{$kbytes_step}_{$max_images}:json";
830c830
< array_push($media_query_conditions, "(min-width: ${media_options['min_width']}px)");
---
> array_push($media_query_conditions, "(min-width: {$media_options['min_width']}px)");
834c834
< array_push($media_query_conditions, "(max-width: ${media_options['max_width']}px)");
---
> array_push($media_query_conditions, "(max-width: {$media_options['max_width']}px)");
Thanks!
from cloudinary_php.
@rlerdorf @plsoucy-tapclicks , the new version 1.20.2 is released.
from cloudinary_php.
Just tested and it works well on PHP 8.2. Thanks @const-cloudinary !
from cloudinary_php.
Related Issues (20)
- Method update of AssetTrait does not update metadata data HOT 4
- Image transformation produces broken URL if public ID ends with .jpg HOT 3
- Fatal declaration error due to monolog change HOT 3
- PHP 8.1 support HOT 5
- Migrate from Travis to GitHub actions HOT 2
- Add PHPStan HOT 1
- Wrong CLOUDINARY_URL HOT 3
- Why does the response I'm getting not reflect the documentation's format? HOT 5
- Missing a way to easily request every asset type HOT 18
- Deprecated: fopen(): Passing null to parameter #3 ($use_include_path) of type bool is deprecated (php 8.1) HOT 1
- Update access mode method not available in SDK HOT 10
- [2.7.1] Why separate package and failure on composer-require-checker HOT 1
- Fatal Error on PHP 7.4 HOT 2
- Bad signature when public id contains commas HOT 5
- Error using defaultvalues in class SetMetadataField HOT 1
- Incorrect URL generated when Public ID of MediaAsset ends with dot + 1-5 characters HOT 3
- Deprecations on PHP 8.2 HOT 1
- Call to undefined function GuzzleHttp\Promise\promise_for() HOT 3
- Get rid of `teapot-php/status-code` dependency HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloudinary_php.