Git Product home page Git Product logo

Comments (5)

strausr avatar strausr commented on August 15, 2024 1

@bernharduw Thank you for the input. We are aware of this and have an open ticket on the issue. I'd be happy to update you as soon as this is resolved.

from cloudinary-react.

strausr avatar strausr commented on August 15, 2024

@bernharduw Thank you for bringing this to our attention. We will re-evaluate it as part of the upcoming release.

from cloudinary-react.

bernharduw avatar bernharduw commented on August 15, 2024

I also stumbled on a performance issue that is related: With <Transformation/> children on the image component, the componentWillReceiveProps method takes a very long time to execute (about 6 seconds on my Mac). The reason for this: all the props are passed to the Configuration class in cloudinary-core, which deep-clones them. The _owner attribute of the children prop points to the parent component, so basically the whole React tree is being cloned on every call of componentWillReceiveProps.

For now, I have put all the transformation props on the Image component, which also works great.

But it would make more sense to blacklist children or whitelist the valid options before using them in any way.

from cloudinary-react.

brettgullan avatar brettgullan commented on August 15, 2024

+1

I’ve encountered the same issue, though it only arose once I called this.setState in another component. For the most part, I’m managing state through Redux, so took a while before this issue became apparent. And a whole lot longer to track down!

Looking forward to a fix for this.

from cloudinary-react.

eitanp461 avatar eitanp461 commented on August 15, 2024

Fixed by #39

from cloudinary-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.