Comments (5)
@bernharduw Thank you for the input. We are aware of this and have an open ticket on the issue. I'd be happy to update you as soon as this is resolved.
from cloudinary-react.
@bernharduw Thank you for bringing this to our attention. We will re-evaluate it as part of the upcoming release.
from cloudinary-react.
I also stumbled on a performance issue that is related: With <Transformation/>
children on the image component, the componentWillReceiveProps
method takes a very long time to execute (about 6 seconds on my Mac). The reason for this: all the props are passed to the Configuration class in cloudinary-core, which deep-clones them. The _owner attribute of the children prop points to the parent component, so basically the whole React tree is being cloned on every call of componentWillReceiveProps
.
For now, I have put all the transformation props on the Image component, which also works great.
But it would make more sense to blacklist children
or whitelist the valid options before using them in any way.
from cloudinary-react.
+1
I’ve encountered the same issue, though it only arose once I called this.setState
in another component. For the most part, I’m managing state through Redux, so took a while before this issue became apparent. And a whole lot longer to track down!
Looking forward to a fix for this.
from cloudinary-react.
Fixed by #39
from cloudinary-react.
Related Issues (20)
- accessing images in subfolders (uploadPreset) HOT 2
- cloudinary-react/samples/photo_album/ does not work HOT 4
- data- and aria- attributes are passed both correct and incorrectly cause a react-dom error HOT 3
- Multiple dependencies no-longer supported HOT 2
- TypeScript Declarations HOT 4
- sourceTypes incorrectly adding video as mimetype when using codec HOT 3
- Issue with versioning URL and On-Demand Download from S3 Bucket HOT 4
- Allow private requests for publicly allowed transformations HOT 1
- Image gallery? HOT 1
- Does the Placeholder component still work? HOT 7
- Images in chrome are not displayed when fetchFormat="auto" HOT 4
- how to use cloudinary with ant designs upload component? HOT 1
- Is Cloudinary-react doesn't support for typescript HOT 1
- TypeError: cld.videoPlayer is not a function HOT 1
- Support for token based authentication? HOT 3
- Getting tags with images HOT 4
- Url encoded characters in public ID not handled well in AdvancedImage component HOT 4
- React 18 release? HOT 2
- In typescript in react app HOT 3
- AdvancedVideo componet issue in Chrome Browser on mobile web
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloudinary-react.