Question about KVStore's put vs put_bytes about workers-rs HOT 3 CLOSED

Hi @eminence.

Why can't put accept bytes? Stated another way: why is there both a put() and put_bytes() ?

Put is intended for arbitrary data that can be serialized to a string and then put into the KV store. The impl ToRawKvValue for [u8] is a left over from this pr and is unintentionally included in the library, so it'll be removed before the library is stabilized.

But in this specific case because of the lack of trait specialization what's actually happening is that the impl<T: Serialize> ToRawKvValue for T impl is being used, creating a number array which isn't allowed by KV. Intended behavior for this is that the value [116, 101, 115, 116] would be written to the KV as a string, but due to a bug it isn't.

put_bytes is the intended way for users to write raw bytes to KV stores. In the future there will be put_byte_stream for streaming bytes and to implement the final type of value for string | ArrayBuffer | ArrayBufferView | ReadableStream accepted by the put function.

Edit: worker-kv 0.5.1 has been released fixing this

from workers-rs.

Just a follow-up & to close this out:

Edit: worker-kv 0.5.1 has been released fixing this

We plan on cutting a new release including all the latest worker-kv goodies by end of next week.

from workers-rs.

Sorry for the additional ping @zebp :) If you can shed some light here, it would be much appreciated!

from workers-rs.