Comments (11)
@prymitive Yes, it works!
from unsee.
Released 0.7.1 with that PR merged, please use that release.
from unsee.
TypeErrors like these are usually caused by modules failed to load, most likely due to an error while parsing JS code.
Sentry would be able to answer this question better than me (developer console could also have some hints), but I suspect that the browser doesn't modern javascript features and some of the modules used needs those, e.g. lru.js.
Are you able to collect any details?
from unsee.
Ok, signed up for a sentry trial.
Apparently the browser is FF 33.0. Not exactly new. As you guessed, there is some parsing error:
SyntaxError: missing ; before statement
ReferenceError: LRUMap is not defined
TypeError: Alerts is undefined
at Unsee</triggerReload/<.success/<(/static/unsee.js:221:33)
at d(/static/managed/js/3.15.0-raven.min.js:2:6300)
So this is basically unfixable without getting the vendor to update the browser?
from unsee.
I'll look into it in a few days. Need to verify how much LRU really helps and whenever it can be reimplemented using something that older browsers would support. No promises but it should be fixable, assuming that's the only code that tv is having problems with. Thanks
from unsee.
Can you try lru.js-v2 branch and see if that helps?
The easiest way would be to build a custom docker image from that branch using:
git clone https://github.com/cloudflare/unsee.git
cd unsee
git checkout lru.js-v2
make docker-image
make run-docker
make run-docker
will spawn a test instance that uses mock data, but it should be enough to do a test.
Let me know if that's enough to fix this issue.
from unsee.
@prymitive Thanks! I've built the image and pushed it to our internal repos now, however I'm not in the office today so I cannot validate how it looks on the actual screens today. I'll post an update as soon as I'm back!
from unsee.
Raised #147 to merge it
from unsee.
Thanks!
from unsee.
ps. you should still ping the vendor to update the browser, 13-Oct-2015 was a long time ago
from unsee.
Browser caching was causing errors with new version of lru.js
, I've tagged 0.7.2 with a small fix.
from unsee.
Related Issues (20)
- Silence on proxied alertmanagers give a 404 HOT 4
- Feature: HTML safe annotations
- Feature: Create silences HOT 3
- Feature: Take username from http header HOT 3
- using nginx HOT 2
- Upgrade moment.js
- Silence comments only appear after a while HOT 4
- How to add Alert manager name for each instance HOT 2
- [0.9.1] Silence on Proxied Alertmanagers returns 404 HOT 16
- WEB_PREFIX ENV not working HOT 2
- gin request metrics contain arbitrary URLs, resulting in high cardinality
- Credentials in URLs are not masked HOT 3
- Panic in semantic version parsing HOT 9
- Silences POST fails with 307 Temporary Redirect due to double-slash in URL HOT 2
- Support alertmanager 0.15.x HOT 5
- Add tls certs to the "curl" example command for silencing
- TLS works for getting alerts, but fails for sending silences? HOT 1
- Basic auth credentials in stdout HOT 1
- Hide top bar and optionally replace with customizable headline HOT 2
- Incompatibility with alertmanager 0.16.x HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unsee.