Git Product home page Git Product logo

Comments (19)

prymitive avatar prymitive commented on June 23, 2024 1

We're done with PRs I think, I'll open the repo and setup travis

from unsee.

prymitive avatar prymitive commented on June 23, 2024 1

Repo is public so closing

from unsee.

prymitive avatar prymitive commented on June 23, 2024

I guess there's one issue - we should tag a release

from unsee.

prymitive avatar prymitive commented on June 23, 2024

Created first milestone, if there's anything else we need please raise a ticket and attach it to this milestone.

from unsee.

jamesog avatar jamesog commented on June 23, 2024

I'm happy to open this once the PRs are all merged. Your suggestions are all fine - using Travis is no problem, we already use it for many other Cloudflare repos.

from unsee.

prymitive avatar prymitive commented on June 23, 2024

No more outstanding PRs, is everyone happy with making this repo public now? This will allow me to tag a release and complete at least first 2 points in this ticket (docker image isn't critical).

from unsee.

jamesog avatar jamesog commented on June 23, 2024

LGTM 👍

from unsee.

prymitive avatar prymitive commented on June 23, 2024

@mattbostock any objections?

from unsee.

mattbostock avatar mattbostock commented on June 23, 2024

No objections from me. Just one question - are we going to use the timestamp format for release tags?

IMHO it'd be more useful to use semantic versioning for a public project.

from unsee.

mattbostock avatar mattbostock commented on June 23, 2024

Also, minor nit, but we should definitely add a screenshot to the README. Maybe using the sample data you created?

from unsee.

prymitive avatar prymitive commented on June 23, 2024

I'm happy with both version schemes, @jamesog you're needed to get a quorum
I'll add a screenshot but let me add more mocked alerts, it would look kinda sad with the current set

from unsee.

prymitive avatar prymitive commented on June 23, 2024

Should we use v prefix for release tags and milestones? I think that v1.0 is more obvious as a tag name than 1.0, same for milestones.

from unsee.

jamesog avatar jamesog commented on June 23, 2024

Yep, I'd prefix with v.

You have your quorum. Let the code be free.

from unsee.

mattbostock avatar mattbostock commented on June 23, 2024

I also agree with 'v' - I believe that's what GitHub uses by default if you create a tag manually.

from unsee.

mattbostock avatar mattbostock commented on June 23, 2024

I'm thinking that, rather than v1.0, we make the first version be v0.0.1. That'll allow for changes (without worrying about backwards compatibility) while the code settles a bit.

Using SemVer, there's a big difference between pre-1.0.0 and 1.0.0 onwards:
http://semver.org/#spec-item-4

from unsee.

prymitive avatar prymitive commented on June 23, 2024

v0.1.0 it is, v0.0.1 sounds like a stub of a project, I think we're past that phase

from unsee.

mattbostock avatar mattbostock commented on June 23, 2024

🎉

from unsee.

prymitive avatar prymitive commented on June 23, 2024

Made a PR for travis - #17
I'm going to ignore docker for now and get back to it later (will raise an internal ticket for myself)

from unsee.

prymitive avatar prymitive commented on June 23, 2024

will deploy a new build internally and if all goes well we'll tag a release

from unsee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.