Comments (4)
Hey! 👋 Are you saying you were able to return an instance of the HTMLResponse
class from that library instead of a Response
? If so, that should be fine, as the HTMLResponse
class extends from Response
, so should inherit its behaviour.
from miniflare.
No I just returned template literal with that library which is why I referenced it, and an error should’ve been thrown because it would in production.
from miniflare.
Ok, I agree there should definitely be an error thrown if the returned response is not a Response
. I'm interested that you say "no errors were thrown" though. When I try run this code I get the following error:
import { html } from "@worker-tools/html";
addEventListener("fetch", e => {
e.respondWith(html`<h1>test</h1>`);
});
[mf:err] GET /: TypeError: Cannot read properties of undefined (reading 'delete')
at Miniflare._Miniflare_httpRequestListener (.../miniflare/src/index.ts:420:26)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
Is this what you're doing/seeing?
from miniflare.
I was using worktop so maybe that automatically wraps things in a response, so I simply wasn't able to use the html because there wasn't a content type or something. I suppose that even in miniflare basically trying to send a string along won't a work if it's not instantiated.
from miniflare.
Related Issues (20)
- Node 21 vitest-environment-miniflare compatibility HOT 1
- [Miniflare 3] Step debugging with multiple workers HOT 2
- Update undici dependency due to vulnerability HOT 1
- [Docs] Miniflare v2 docs removed? HOT 3
- How to migrate Jest unit tests to Miniflare V3? HOT 1
- Support for typescript. HOT 1
- Is is it possible to collect coverage with vitest-environment-miniflare? HOT 2
- Increase better-sqlite3 compatibility HOT 1
- Uncaught error when initializing two top level WASM modules
- Multiple nodejs_compat packages missing (`crypto`, `path`, etc) HOT 4
- Fix CVE-2024-24758 HOT 3
- Type confusion HOT 1
- @miniflare/shared should not depend on @types/better-sqlite3 HOT 1
- Vitest bug: "Error: ENOENT: no such file or directory" HOT 2
- Workers: Error when an undefined value is exported in dev environment
- Type incompatibility issue between miniflare and workers-types HOT 4
- BUG: cannot install this library in node 22, please update better-sqlite3 HOT 1
- MiniflareCoreError [ERR_RUNTIME_FAILURE]: The Workers runtime failed to start. HOT 7
- How to test with `nodejs_compat` workers?
- How to use Worker's new native RPC feature? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miniflare.