Git Product home page Git Product logo

Comments (3)

rgooch avatar rgooch commented on June 12, 2024

Actually, it's intended behaviour. What you propose would prevent the ability to create images with sparse filters.

from dominator.

michaeljs1990 avatar michaeljs1990 commented on June 12, 2024

Ah ok, I remember reading about sparse images in the docs are just went and refreshed my memory. It would be nice if you had to explicitly tell dominator that you wanted a sparse image with maybe an entry in the manifest file such as "Sparse": true but the change for this would be breaking.

It seems like having an empty triggers file and having no triggers.add do the same thing as far as I can tell. Although if you have to have the filter.add file in order to not make it a sparse image it would seem requiring triggers.add makes things more consistent.

from dominator.

rgooch avatar rgooch commented on June 12, 2024

While the filters and triggers seem similar, they different in an important way, so I don't see a way to make their configuration exactly the same.

A filter is a list of exclusions when patching. An empty filter means exclude nothing. A missing filter has a special meaning to not delete files, but has no exclusions.

A trigger is simply a list of actions. An empty list of triggers is the same as no triggers. There isn't an extra magical state like with filters.

Closing, as I don't want to introduce a breaking change over this minor wart.

from dominator.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.