Comments (3)
Actually, it's intended behaviour. What you propose would prevent the ability to create images with sparse filters.
from dominator.
Ah ok, I remember reading about sparse images in the docs are just went and refreshed my memory. It would be nice if you had to explicitly tell dominator that you wanted a sparse image with maybe an entry in the manifest file such as "Sparse": true
but the change for this would be breaking.
It seems like having an empty triggers file and having no triggers.add do the same thing as far as I can tell. Although if you have to have the filter.add file in order to not make it a sparse image it would seem requiring triggers.add makes things more consistent.
from dominator.
While the filters and triggers seem similar, they different in an important way, so I don't see a way to make their configuration exactly the same.
A filter is a list of exclusions when patching. An empty filter means exclude nothing. A missing filter has a special meaning to not delete files, but has no exclusions.
A trigger is simply a list of actions. An empty list of triggers is the same as no triggers. There isn't an extra magical state like with filters.
Closing, as I don't want to introduce a breaking change over this minor wart.
from dominator.
Related Issues (9)
- FilterLines documentation HOT 4
- Add support for Prometheus metrics HOT 1
- fsbench and thus subd can't handle ZFS filesystems HOT 6
- Enable computed-files inheritance HOT 1
- Allow resolv.conf config via files config HOT 1
- Race conditions in the herd package HOT 4
- Please correct certificate for https://cloud-foundations.org and provide information about the org. HOT 4
- cannot use use dominator as a module depenency in MacOS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dominator.