Comments (14)
For correct configure it is needed.
Problem / Behavier of opentx 2.1.x.
Maybe we can provide an empty Modelfile.
from mavlink_frskysport.
Hi Clooney, i made an modelfile under companion 2.1.1 with the telemetry settings according your pictures. You can retrieve it from https://drive.google.com/folderview?id=0BxM1Ej9W_KZ7flI0cFJsaGZwTDVId2stSkxQT29OTmhpUF9pc0FleUxkUGl2UWRqQzV5NkE&usp=sharing
2 Filefersions are in that folder .eep and .zip
from mavlink_frskysport.
I also copied my Model to SD-Card.
Model provided with commit: 3d1298c
Filename: Model000-2015-09-09.bin
Directory: MavLink_FrSkySPort/Lua_Telemetry/DisplayApmPosition/MODELS
Maybe you can test it.
Please give a feedback if it is working, so I can close issue.
btw. openTX2.1.3 is released.
Major improvement for us:
Telemetry sensors are no longer continuously detected, it is now necessary to go to the telemetry setup page and manually select the “Discover new sensors” menu item. This prevents creation of non-existing sensors in case of transmission errors, and allows excluding sensors that are received but considered uninteresting.
from mavlink_frskysport.
Anyone tested the provided modelfile?
or do we have still an issue here?
from mavlink_frskysport.
I setup the parameters manually using your pictures, which works OK although a little confusing. I did this because I have some nonstandard things setup in my model. However these are things that should probably all be set for a sane apm FC setup so perhaps supplying them in a model file would help new users. I'll try blanking/resetting my taranis and trying your model file.
from mavlink_frskysport.
Did you already test the model file?
from mavlink_frskysport.
imo, it is also possible to extract sensor data in lua scripts.
for example "lon" and "lat" are available in "GPS" table. so i think at least there is no need to configure sensors manually. we know all data we send and sensor ids. so it must possible to get them in lua. i will try this next for cells Z1-Zx and Cmin. currently we define custom sensors for this. but a look inside this file https://github.com/opentx/opentx/blob/8b8391101779d85c48e2709c560f8ee78f65111e/radio/src/lua_api.cpp offers other choices to get them simple via lua.
from mavlink_frskysport.
For Cells, I´m not sure, but for min and max Values it should be possible by adding "-min" or "-max".
like
getValue("VFAS-min")
from mavlink_frskysport.
think its more like
local MyCells = {} --init simple empty table
local MyCellOne = 0
local MyCellTwo = 0
-- and so on
MyCells = getValue("CELLS") -- do not know but at lua_api.cpp line 166 its telemetry item "cells"
if MyCells == table then
if MyCells[1] ~= NIL then
MyCellOne = MyCells[1]
end
-- and so on for each cell
end
i am not really sure but for gps this works. similar to "if (telemetryItem.cells.count == 0)" on line 166 in lua_api.cpp for cells, you will find for gps something like this "telemetryItem.gps....." .
all this need a try. but if it will work, imo there is no need to setup sensors manually any more.
/g
wolke
from mavlink_frskysport.
Hi, have a question and don't know if the is the right place to ask, BTW awsome code, i love this functionality on my Quad... I have a external FrSKY FLVSS and FAS connected to my X8R, I see you just added the option to specify if an external FAS is connected. I actually just added that code the other day and now I can use yours, if I leave the "USE_SINGLE_CELL_MONITOR " commented out will that then pick up my external FLVSS or do i need to do something else to remove the FLVSS from your code..
from mavlink_frskysport.
@wolkstein:
yeah, would be good if that works. this would save a lot of telemetry slots.
@mamacher:
You are right. Should look like this:
/*
* *******************************************************
* *** Enable Addons: ***
* *******************************************************
*/
#define USE_FAS_SENSOR_INSTEAD_OF_APM_DATA // Enable if you use a FrSky FAS Sensor.
//#define USE_SINGLE_CELL_MONITOR // Disable if you use a FrSky FLVSS Sensor. - Setup in LSCM Tab
//#define USE_AP_VOLTAGE_BATTERY_FROM_SINGLE_CELL_MONITOR // Use this only with enabled USE_SINGLE_CELL_MONITOR
from mavlink_frskysport.
I will close this, due to the fact we can't change this.
We can only improve in small parts, like GPS and maybe Cells.
If someone still thinks we need this, please reopen or open a new issue.
from mavlink_frskysport.
@Clooney82 Should the Wiki be updated to include the Discover new sensors step?
from mavlink_frskysport.
I just left a comment on another issue about GPS sensor but having spotted this issue thought it would be good to share my findings and method for easier sensor setup.
I started tonight by clearing all sensors on my Taranis (I was testing the inverter native FrSky telem available now from APM 3.3 and cleared them to switch back to the Teensy), and I chose 'Discover new sensors' to add the majority of sensors back on to my model. All I had to edit once done was to rename Temp1 -> T1 and Temp2 -> T2, then add the calculated sensors (like Cmin).
I also discovered tonight that doing the discovery of sensors this way is the only means of getting a working GPS sensor configured. Manually setting up GPS either on the taranis directly, or in Companion then downloading, results in a broken GPS sensor (it displays just a 5-6 character numeric rather than the Lat/Long values as expected. Having a working GPS sensor means that I now have a fully functional radar display (which I have never managed until now on OTx2.1)
from mavlink_frskysport.
Related Issues (20)
- Brake Mode not displaying/calling - code fix detailed in post HOT 6
- Compatibility with PX4 flightstack HOT 2
- No GPS data and energy calculations shown HOT 2
- Arduino compiling problem HOT 5
- Hdg value only sent whilst 3d GPS fix HOT 5
- telemetry pass through in opentx HOT 24
- Findings for improoving the documentation and function HOT 4
- Pre-Arm Errors - Repeated Audio Notifications HOT 1
- Support the latest FrSkySportTelemetry library HOT 1
- telem1.lua - Not enough memory HOT 2
- offset.lua syntax error and wrong flight mode indication HOT 7
- Replace offset.lua mixer script with telemetry config page HOT 2
- CELLS CONFIGURATION Zx HOT 5
- Voice message refactoring - dev chat
- Request or need help to setup HOT 17
- Script syntax error HOT 3
- USE_FLVSS_FAKE_SENSOR_DATA doesn't show the single cell value HOT 1
- Precision/Threshold HOT 2
- collect2.exe: error: ld returned 1 exit status HOT 1
- collect2.exe: error: ld returned 1 exit status
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mavlink_frskysport.