Eldoc error when running boot repl about inf-clojure HOT 10 CLOSED

from inf-clojure.

This has nothing to do with the emacs version, but basically involves the repl type detection. The first we try is lumo, but this fails because the normal Clojure nrepl does not of course has js/ in its namespaces.
I will need to add in first place code for detection nrepl and then if it is not that, try all the others. In this way we are sure to rule out attempts that cause evaluation failures like this. @bbatsov

from inf-clojure.

I will need to add in first place code for detection nrepl and then if it is not that, try all the others. In this way we are sure to rule out attempts that cause evaluation failures like this. @bbatsov

There's not such thing as nREPL here - that's actually REPLy (which uses nREPL internally, but inf-clojure can't really leverage nREpL directly so it shouldn't care about this). I REPLy repl should be treated as a regular Clojure REPL. Btw, lein and boot start exactly the same repl, so I'm pretty confused why this works with lein, but not with boot.

from inf-clojure.

This has nothing to do with the emacs version, but basically involves the repl type detection. The first we try is lumo, but this fails because the normal Clojure nrepl does not of course has js/ in its namespaces.

On a related note - shouldn't there also be some REPL type detected in the end regardless what was checked first? Seems that's the real issue here.

from inf-clojure.

from inf-clojure.

I guess they can simply add some var similar to *clojure-version* to simplify the process.

from inf-clojure.

As per discussion in linked PR, the issue is not as easy as it seems because there is no common way to detect a Repl type and folks maintening them are not willing to compromise at the moment.
There will be one once a common protocol like unrepl catches up.

So my workaround would be to kind of detect and skip the inevitable error we will receive (js/ is not defined in nrepl for instance) and return a false in the detection function.

from inf-clojure.

Another problem I found is related to the Ansi code the repls are sending. The read function fails and throws an error. I can ignore that for now but I need to get rid of the ansi codes somehow or nothing is readable otherwise. Lumo does not have this problem because we are using it in dumb mode.

from inf-clojure.

I found a package that does the ANSI filtering. This is the commit to take inspiration from.

from inf-clojure.

The error should be solved with the Caveat added to not use colors for now: boot repl -C is now used by inf-clojure

from inf-clojure.